Fix Output capture from background threads#4021
Open
MUFFANUJ wants to merge 5 commits into
Open
Conversation
|
|
krassowski
reviewed
Jun 15, 2026
Contributor
|
@MUFFANUJ maybe you could also add an end-to-end playwright test demonstrating that the capture from background threads works as intended? |
Contributor
|
re-approved workflows. |
krassowski
suggested changes
Jun 18, 2026
Contributor
|
Approved runner again. |
Contributor
|
@MUFFANUJ it looks like the test failed? |
Member
|
The CI failure may be related to the new jupyterlab release. Can you try pinning jupyterlab in the ui-tests for now here https://github.com/jupyter-widgets/ipywidgets/blob/main/.github/workflows/tests.yml#L147?
|
Contributor
|
Oh, right it is related. The giveaway is |
Contributor
|
What do you think @martinRenou? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4020
Set the current
IPythonparent when entering anOutputcontext so output generated in background threads is routed to the widget with ipykernel 7.