Conversation
The "controller" here is not the control channel, it is the socket used for internal communication between the control and the shell channels (typically used for stopping the shell thread, or for sending code to execute to start the debugger). It must not be removed. |
Since the tests passed even without it, maybe we should extend the s.t. they would not pass without these handlers |
|
I would have expected the |
| { | ||
| if (!p_loop) | ||
| { | ||
| std::cerr << "No loop provided, using default loop." << std::endl; |
There was a problem hiding this comment.
...overenthusiastic cleanup
but it was not failing...and restarting the kernel (ie python kernel) seemed to work just fine. |
|
Indeed that's weird. Anyway, we'll need it for the debugger. |
remove controller handling from xuv_runner since that only needs to handle the shell. the controll messages are handled via the xcontrol_default_runner (thats intended, isnt it @IsabelParedes ?)XEUX_UV_API->XEUS_UV_API)xeus-uv.hpp->xeus_uv.hpp)#include "xeus-uv/xserver_uv.hpp"in"xeus-uv/xserver_uv.cpp". With that beeing missing, theXEUS_UV_API` visibility was not considered for that symbol which made that symbol hidden in the dll/soOpen questions / points:
xhook_baseto something more descriptive