Skip to content

Commit 0fe100e

Browse files
authored
Merge pull request #896 from minrk/conda-47
conda 4.7.5
2 parents f298609 + 5eca3ca commit 0fe100e

File tree

3 files changed

+11
-13
lines changed

3 files changed

+11
-13
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,4 +87,4 @@ test/%: ## run tests against a stack
8787
@TEST_IMAGE="$(OWNER)/$(notdir $@)" pytest test
8888

8989
test/base-notebook: ## test supported options in the base notebook
90-
@TEST_IMAGE="$(OWNER)/$(notdir $@)" pytest test base-notebook/test
90+
@TEST_IMAGE="$(OWNER)/$(notdir $@)" pytest test base-notebook/test

base-notebook/Dockerfile

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
# Copyright (c) Jupyter Development Team.
22
# Distributed under the terms of the Modified BSD License.
33

4-
# Ubuntu 18.04 (bionic) from 2018-05-26
5-
# https://github.com/docker-library/official-images/commit/aac6a45b9eb2bffb8102353c350d341a410fb169
6-
ARG BASE_CONTAINER=ubuntu:bionic-20180526@sha256:c8c275751219dadad8fa56b3ac41ca6cb22219ff117ca98fe82b42f24e1ba64e
4+
# Ubuntu 18.04 (bionic) from 2019-06-12
5+
# https://github.com/tianon/docker-brew-ubuntu-core/commit/3c462555392cb188830b7c91e29311b5fad90cfe
6+
ARG BASE_CONTAINER=ubuntu:bionic-20190612@sha256:9b1702dcfe32c873a770a32cfd306dd7fc1c4fd134adfb783db68defc8894b3c
77
FROM $BASE_CONTAINER
88

99
LABEL maintainer="Jupyter Project <[email protected]>"
@@ -60,18 +60,19 @@ RUN echo "auth requisite pam_deny.so" >> /etc/pam.d/su && \
6060
fix-permissions "$(dirname $CONDA_DIR)"
6161

6262
USER $NB_UID
63+
WORKDIR $HOME
6364

6465
# Setup work directory for backward-compatibility
6566
RUN mkdir /home/$NB_USER/work && \
6667
fix-permissions /home/$NB_USER
6768

6869
# Install conda as jovyan and check the md5 sum provided on the download site
69-
ENV MINICONDA_VERSION=4.5.12 \
70-
CONDA_VERSION=4.6.14
70+
ENV MINICONDA_VERSION=4.6.14 \
71+
CONDA_VERSION=4.7.5
7172

7273
RUN cd /tmp && \
7374
wget --quiet https://repo.continuum.io/miniconda/Miniconda3-${MINICONDA_VERSION}-Linux-x86_64.sh && \
74-
echo "866ae9dff53ad0874e1d1a60b1ad1ef8 *Miniconda3-${MINICONDA_VERSION}-Linux-x86_64.sh" | md5sum -c - && \
75+
echo "718259965f234088d785cad1fbd7de03 *Miniconda3-${MINICONDA_VERSION}-Linux-x86_64.sh" | md5sum -c - && \
7576
/bin/bash Miniconda3-${MINICONDA_VERSION}-Linux-x86_64.sh -f -b -p $CONDA_DIR && \
7677
rm Miniconda3-${MINICONDA_VERSION}-Linux-x86_64.sh && \
7778
echo "conda ${CONDA_VERSION}" >> $CONDA_DIR/conda-meta/pinned && \
@@ -111,10 +112,7 @@ RUN conda install --quiet --yes \
111112
fix-permissions $CONDA_DIR && \
112113
fix-permissions /home/$NB_USER
113114

114-
USER root
115-
116115
EXPOSE 8888
117-
WORKDIR $HOME
118116

119117
# Configure container startup
120118
ENTRYPOINT ["tini", "-g", "--"]
@@ -125,6 +123,9 @@ COPY start.sh /usr/local/bin/
125123
COPY start-notebook.sh /usr/local/bin/
126124
COPY start-singleuser.sh /usr/local/bin/
127125
COPY jupyter_notebook_config.py /etc/jupyter/
126+
127+
# Fix permissions on /etc/jupyter as root
128+
USER root
128129
RUN fix-permissions /etc/jupyter/
129130

130131
# Switch back to jovyan to avoid accidental container runs as root

scipy-notebook/Dockerfile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@ RUN apt-get update && \
1515
USER $NB_UID
1616

1717
# Install Python 3 packages
18-
# Remove pyqt and qt pulled in for matplotlib since we're only ever going to
19-
# use notebook-friendly backends in these images
2018
RUN conda install --quiet --yes \
2119
'conda-forge::blas=*=openblas' \
2220
'ipywidgets=7.5*' \
@@ -43,7 +41,6 @@ RUN conda install --quiet --yes \
4341
'beautifulsoup4=4.7.*' \
4442
'protobuf=3.7.*' \
4543
'xlrd' && \
46-
conda remove --quiet --yes --force qt pyqt && \
4744
conda clean --all -f -y && \
4845
# Activate ipywidgets extension in the environment that runs the notebook server
4946
jupyter nbextension enable --py widgetsnbextension --sys-prefix && \

0 commit comments

Comments
 (0)