-
Notifications
You must be signed in to change notification settings - Fork 3k
Add a way to easily test units #1386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a way to easily test units #1386
Conversation
Works locally!
|
This seems to be ready. |
@mathbunnyru can you help me help you get this reviewed by applying the autoformatting as a dedicated PR? For me, the main point of having autoformatters is to avoid ending up with PRs including formatting changes alongside logic changes to help the review process and avoid cluttering git history when git blame is used. I suggest we do Oh... I tried that and conclude we don't have autoformatting regarding trailing commas or similar. I would suggest we use UPDATE: I created #1387 |
These were not automatic changes. |
@consideRatio you asked to make it easier for you to review these changes. I made a separate PR, which changes the style in the test files. Then I'm going to merge master to the branch in this PR and this change will be purely adding unit tests. In parallel, I'll ask you to merge master in your branch and rerun black. |
@consideRatio now this is purely feature add. |
@consideRatio now it's your turn to review 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made one suggestion that I think can make this code more robust in case we want to publish to someplace else than dockerhub such as quay.io, but other than that i think this looks amazing! Nice work!
Co-authored-by: Erik Sundell <[email protected]>
LGTM! |
Full description is in the issue.
Fix: #1353