Skip to content

Add some typing to tests #1573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 18, 2022
Merged

Conversation

mathbunnyru
Copy link
Member

Main change is to add some typing, but there are some other changes as well.
Sorry they are all packed in one PR, but there are no significant changes here.

@mathbunnyru
Copy link
Member Author

Forgot to mention this - with typing, implementing new changes becomes easier (IDEs like VS Code do much much better with typing).
And, I didn't add typing in all possible places, but I think this is better than nothing.

Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! I haven't used these type annotations actively and have little experience overall, but it sounds very reasonable to go for!

@mathbunnyru
Copy link
Member Author

amd64 works fine, so merging this.

@mathbunnyru mathbunnyru merged commit f162376 into jupyter:master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants