Skip to content

Conversation

@thomasjm
Copy link
Contributor

@thomasjm thomasjm commented May 30, 2024

Pass different arguments to pandoc depending on whether the version is >= 3.0, to fix #2017.

@thomasjm thomasjm force-pushed the fix-asciidoc branch 2 times, most recently from 33f36f3 to d00d056 Compare May 30, 2024 22:19
@takluyver
Copy link
Member

The fix looks good to me, but I think the asciidoc tests should be extended to check for Markdown cells. The notebook used in test_export already has Markdown cells, but the test still passes if they're missing from the output.

(I'm also kind of surprised that nbconvert carries on if pandoc fails, but that's a bigger question)

@thomasjm
Copy link
Contributor Author

thomasjm commented Aug 6, 2024

Okay, added a test. I manually confirmed that the new test fails without the fix in this branch.

@takluyver
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nbconvert export omits markdown cells

3 participants