CSS issue when the Notebook windowing mode is set to `full`

[jtpio]

Testing on the latest main, which includes the recent changes that landed in JupyterLab w.r.t windowing mode, it looks like the CSS is off:

This is likely related to an underlying DOM structure change, which affects the CSS customizations in Notebook.

[jtpio]

Adding to 7.1.x since full is not the default windowing mode.

[jtpio]

Marking as a "good first issue" if someone would like to have a look:

The windowing mode can be set to full via the settings editor:

This will also likely require tweaking some CSS depending on the DOM structure: https://github.com/jupyter/notebook/blob/main/packages/notebook-extension/style/base.css

[kgaurav8026]

Hi @jtpio,
I’m interested in contributing to JupyterLab, and I’d like some additional context regarding the issue related to cell alignment. From what I understand, the issue pertains to the misalignment of the cell box when windowing. Specifically, should the cell box be centered on the screen?

[jtpio]

Yes it should be centered like when using the default mode:

[v-lozko]

Hello, would it be possible to have this assigned to me?

Thanks

[kgaurav8026]

Hello, would it be possible to have this assigned to me?

Thanks

I'm also working to resolve the issue. If you find a solution, you can submit a PR I guess. Assigning it won't be beneficial.

[v-lozko]

It will be so efforts arent duplicated, so work on it. if you can't/dont have time let me know and i can take a stab at it

[kgaurav8026]

It will be so efforts arent duplicated, so work on it. if you can't/dont have time let me know and i can take a stab at it

Ok sure. I will let you know if I'm not able to complete it. I'm currently halfway there