Fix markdown mode loading #1757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and merge object config values with defaults (e.g. Cell.cm_config)
fixes omitted codemirror config due to ignoring options_default. load options_default via config defaults (modifying options_default at runtime has no effect).
if ipythongfm is defined after notebook is loaded, re-load it in all cells that are using it.
|
This fixes the issue for me, thanks. |
|
I have tested and it fixes Markdown syntax highlighting and line soft wrapping for me. Merging... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and options_default in general, which has been ignored entirely for most cell types since #1676.
This attempts to resolve the separation of config and Class.options_default by using options_default as the defaults for the cell's config objects, eliminating a separate notion of 'options' and 'config'.
For some reason, I also had to add an explicit 'reload ipythongfm' action after that mode is defined, since we are no longer guaranteed that the IPython markdown mode is defined when markdown cells are getting created. I'm not sure exactly when that stopped working, but I imagine it's due to webpack and require fighting with each other (cc @blink1073)
I also added to the config section the ability to get the whole class-config object merged with defaults, since that's the data structure we want here.
Closes #1743