Trigger 'clear_output.CodeCell' before clearing output #2394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@jasongrout Care to review? |
Member
gnestor
commented
Apr 13, 2017
| } | ||
|
|
||
| this.output_area.clear_output(false, true); | ||
| this.clear_output(false, true); |
Contributor
Author
There was a problem hiding this comment.
@jasongrout I think that this.clear_output should be used instead of this.output_area.clear_output because this.clear_output triggers events whereas this.output_area.clear_output doesn't.
Contributor
Author
There was a problem hiding this comment.
So I think this diff should make it into the notebook via the PR or #2411
jasongrout
added a commit
to jasongrout/notebook
that referenced
this pull request
Apr 13, 2017
Thanks to @gnestor for this, from PR jupyter#2394.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #2297
This will trigger the
clear_output_CodeCellevent before clearing the output area, allowing extensions to clean up before clearing the output element. This also triggers the event onCodeCell.execute.