Deprecate duplicate functions from utils. #427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sad Travis :( |
You know you can head to the travis page and restart just the failing test ? |
| cursor_pos += cm.getLine(i).length + 1; | ||
| } | ||
| return cursor_pos; | ||
| console.warn('utils.to_absolute_cursor_pos(cm, pos) is deprecated us cm.indexFromPos(cursor)'); |
There was a problem hiding this comment.
... is deprecated us, you want to put use? by? I don't get the phrase written as is...
below it is the same... thanks!
minrk
added a commit
that referenced
this pull request
Sep 15, 2015
Deprecate duplicate functions from utils.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #245