Fixed issue when opening notebook with %20 in filename#7848
Open
og-khushalpatel wants to merge 1 commit intojupyter:7.2.xfrom
Open
Fixed issue when opening notebook with %20 in filename#7848og-khushalpatel wants to merge 1 commit intojupyter:7.2.xfrom
og-khushalpatel wants to merge 1 commit intojupyter:7.2.xfrom
Conversation
Contributor
|
|
Author
|
Hi @krassowski @jtpio , I’m following up on this PR in case it got buried. Please let me know if any changes are needed from my side. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Fixes #7823
Code changes
The fix wraps path with
URLExt.encodeParts()inpathopener.tsbefore passing it toURLExt.join(). Previously, paths containing special characters like literal%20(a filename actually named A%20B.ipynb) were passed unencoded, causing the URL constructor to misinterpret%20as an already-encoded space.URLExt.encodeParts()properly percent-encodes each path segment, so%20in a filename becomes%2520in the URL, preserving the literal characters.User-facing changes
Screencast.from.2026-03-04.11-49-26.webm