Fix the HydroShare download url #1488
Merged
+28
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update the tests for updated hydroshare download location
for more information, see https://pre-commit.ci
rgaiacs
approved these changes
Nov 19, 2025
Contributor
rgaiacs
left a comment
rgaiacs
left a comment
There was a problem hiding this comment.
Thanks for the contribution. It looks good to me and all tests are passing. I had a minor question.
| conn.status_code == 200 | ||
| and conn.headers["content-type"] != "application/zip" | ||
| while conn.status_code == 200 and not conn.url.startswith( | ||
| f"https://s3.hydroshare.org/bags/{resource_id}.zip" |
Contributor
There was a problem hiding this comment.
Would be possible to test
conn.url != f"https://s3.hydroshare.org/bags/{resource_id}.zip"
instead of
not conn.url.startswith(f"https://s3.hydroshare.org/bags/{resource_id}.zip")
Contributor
Author
There was a problem hiding this comment.
That is a good question. It is not possible to test the whole url because a query parameter follows which includes a temporary authorization signature.
GeorgianaElena
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HydroShare no longer uses irods as a fileserver and now uses S3. The S3 server serves the downloads and this broke integration with repo2docker.
I have verified the changes work with several HydroShare resources. I also updated the unit tests around HydroShare as best as I could. There are 2 tests in
tests/unit/contentproviders/test_hydroshare.pythat fail. These tests fail because doi.org is blocking the requests tohttps://doi.org/api/handles/to resolve the doi. I observed this behavior when making requests locally using the requests library and curl. I was only able to get a response fromdoi.orgwhen I made the request through my web browser.