Skip to content

fix: restore support for python>=3.7,<3.9 #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2023
Merged

fix: restore support for python>=3.7,<3.9 #311

merged 1 commit into from
May 18, 2023

Conversation

pdhall99
Copy link
Contributor

@pdhall99 pdhall99 commented May 17, 2023 •
edited
Loading

Fix #309.

Tests pass for python 3.7-3.11 except test_handlers.test_can_apply_ruff, but the presence of the debugger suggests this might be expected. Is that right?

@ryantam626
Copy link
Collaborator

Thanks for this!
Indeed that test is expected to fail, I apparently has checked in the wrong code in my refactor - whoops.
I will fix that in another PR.

@ryantam626 ryantam626 merged commit af927ea into jupyterlab-contrib:master May 18, 2023
@krassowski krassowski added the bug Something isn't working label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minimum Python version
3 participants
@pdhall99 @ryantam626 @krassowski