Conversation
fcollonval
left a comment
There was a problem hiding this comment.
Thanks @cronan03
First comment, about git usage, I recommend you to use a specific branch in your fork to push changes; see that explanation using forking workflow with feature branch.
The dummy test extension is pushed as part of the changes. That is unwanted. To remove the files from this PR but not from your local copy, you can execute the following command:
git rm --cached -r tests/dummy
fcollonval
left a comment
There was a problem hiding this comment.
Here are a list of simplification you should be able to do.
We will not extract the commands enable/disable, lock/unlock, list, link/unlink, check, install/uninstall and update commands. So we will focus on develop, build and watch. And we will import also a utilities command line (I'll explain that on our call).
jupyter_builder/coreconfig.py
Outdated
There was a problem hiding this comment.
You should be able to remove this file
jupyter_builder/jupyterlab.py
Outdated
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
fcollonval
left a comment
There was a problem hiding this comment.
Thanks @cronan03
Let's merge this to move forward.
Add the
developcommand and scaffolding of the new command line tool.