Skip to content

Modify API to optionally create a document room if it does not exist. #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Darshan808
Copy link
Member

Fixes #328

Description

This PR adds support for creating a document room if it does not already exist.

  • Introduces a new create argument to the get_document method.
  • If the room for a given document does not exist and create=True, a new room is created.
  • The document is then returned with the newly created room.

Looking forward to feedbacks!

@Darshan808 Darshan808 requested a review from krassowski June 6, 2025 17:59
Copy link
Contributor

github-actions bot commented Jun 6, 2025

Binder 👈 Launch a Binder on branch Darshan808/jupyter-collaboration/modify_get_document_api

@Darshan808 Darshan808 added the enhancement New feature or request label Jun 6, 2025
@Darshan808 Darshan808 requested a review from krassowski June 17, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An API to create a document room if it does not exist?
3 participants