Change default value for cleanup to False in latex_cleanup
#251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
krassowski
reviewed
Jul 11, 2025
| @@ -12,7 +12,7 @@ | |||
| from .util import run_command | |||
|
|
|||
| @contextmanager | |||
| def latex_cleanup(cleanup=True, workdir='.', whitelist=None, greylist=None): | |||
| def latex_cleanup(cleanup=False, workdir='.', whitelist=None, greylist=None): | |||
There was a problem hiding this comment.
Does it work? It would seem this default is not used in:
jupyterlab-latex/jupyterlab_latex/build.py
Lines 306 to 307 in db3dd9b
Can it be changed on the trait level?
jupyterlab-latex/jupyterlab_latex/config.py
Lines 29 to 30 in 58abc9c
There was a problem hiding this comment.
Also I guess the help message should clarify that it is more aggressive than just out/aux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear maintainers,
I'm planning to use this extension in production together with jupyterlab-git.
In this pull request I'm suggesting to change the default value of
cleanupin thelatex_cleanupcontext manager toFalse: I believe this is a safer default solution (see #158, #124).Thank you for considering it.