Skip to content

Handle the case when the Playwright config defines projects #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jtpio merged 2 commits into from
Jun 25, 2025
Merged

Handle the case when the Playwright config defines projects #256

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8d4e16
Handle the case when the Playwright config defines projects
jtpio Jun 24, 2025
04c92ac
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions .github/actions/update-snapshots/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ inputs:
browser:
description: The playwright browser to install (one of [`chromium`, `firefox`, `webkit`])
required: false
default: chromium
default: ""
continue_on_error:
description: Whether to continue on error when updating snapshots or not (one of [`yes`, `no`]).
required: false
Expand Down Expand Up @@ -76,7 +76,7 @@ runs:
${{ inputs.npm_client }} install
# Force installing the dependencies
npx playwright install-deps || true
${{ inputs.npm_client }} run playwright install ${{ inputs.browser }}
${{ inputs.npm_client }} run playwright install ${{ inputs.browser || 'chromium' }}

- name: Wait for the server
if: ${{ inputs.start_server_script != 'null' }}
Expand All @@ -85,12 +85,22 @@ runs:
resource: ${{ inputs.server_url }}
timeout: 360000

- name: Generate new snapshots
- name: Generate new snapshots (no browser specified)
# To handle the case when the configuration file defines projects
if: ${{ inputs.browser == '' }}
# Get as much update as possible
continue-on-error: ${{ inputs.continue_on_error == 'yes' }}
shell: bash -l {0}
working-directory: ${{ inputs.test_folder }}
run: ${{ inputs.npm_client }} run ${{ inputs.update_script }} --browser '${{ inputs.browser }}'
run: ${{ inputs.npm_client }} run ${{ inputs.update_script }}

- name: Generate new snapshots (with browser)
if: ${{ inputs.browser != '' }}
# Get as much update as possible
continue-on-error: ${{ inputs.continue_on_error == 'yes' }}
shell: bash -l {0}
working-directory: ${{ inputs.test_folder }}
run: ${{ inputs.npm_client }} run ${{ inputs.update_script }} --browser ${{ inputs.browser }}

- name: Compress snapshots
if: ${{ runner.os == 'Linux' }}
Expand Down
Loading