allow configuring the path of the contents directory - #346
Open
keewis wants to merge 3 commits into
Open
Conversation
This will make sure that timing problems will never arise, and if the contents are at `_build/contents` (or rather, `_build/jupyterlite-contents`) cleaning up after the end of the process is not really required.
for more information, see https://pre-commit.ci
Contributor
Author
|
reading the configuration docs, what |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the one remaining issue I have before being able to merge the PR that adds
try_examplesto thexarraydocs.Basically, I would run sphinx once and then retry again after making changes, and if the first run exited with a non-zero exit code the second run would try to execute all the notebooks in the
_contentsdirectory. However, if I were to add_contentstoexclude_patternsjupyterlitewouldn't be able to find the notebooks in_contents.As far as I can tell, changing the path from
_contentsto_build/contents(or_build/jupyterlite-contents) would always succeed, and wouldn't get confused byexclude_patterns. So what I did was:cc @agriyakhetarpal