Skip to content

Bug/Improvement: Correct handling of message sending #143

Closed
@martenrichter

Description

@martenrichter

Recently a lot of bug reports regarding jupyter lite widget interactivity being broken:
#133
jupyterlite/jupyterlite#1465
jupyter-book/thebe#771
jupyter/try-jupyter#54

I have ran jupyter lite for two days in the debugger (see here my post about it here:
#133
).

And I am now relatively confident that the incomplete implementation of ``get_parentinkernel.py` and the js side:

is causing the trouble. As the control and shell channel parent is mixing through this simplification.
In contrast to:
https://github.com/ipython/ipykernel/blob/188f39c509f1056c3784aad6954498f31de955a3/ipykernel/kernelbase.py#L622

So I think that a patch for this behavior is required. And this may fix the issues. Do you agree?

Are you open for PR? (But I must say, I am very experienced in C++ and js (and a bit in ts), but not in python, but I think the changes do not require much understanding of the language details, so it is possible that I will give up, if I fail). Also I am not so sure how I can test the changes on pyodide-kernel alone. So input is appreciated.

P.S: I hope it is ok to open a separate issue, I thought in this way it is a bit more organized.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions