Skip to content

refactor(connector): Move connector mappings and endpoints to dedicated modules #8562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

refactor(connector): Move connector mappings and endpoints to dedicated modules #8562

merged 1 commit into from
Jul 9, 2025

Conversation

awasthi21
Copy link
Contributor

@awasthi21 awasthi21 commented Jul 7, 2025 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

1)Renamed configs.rs → connector_endpoints.rs in hyperswitch_domain_models
2)Moved connector mapping logic from types/api.rs to new types/api/connector_mapping.rs
3)Created new types/connector_transformers.rs for connector transformation logic
4)Extracted connector transformer implementations from types/transformers.rs

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

No testing was required here; only code refactoring was done.
Cypress checks should cover this

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@awasthi21 awasthi21 self-assigned this Jul 7, 2025
@awasthi21 awasthi21 requested review from a team as code owners July 7, 2025 04:03
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Jul 7, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/core/revenue_recovery/types.rs  99% smaller
  crates/router/src/types/api.rs  1% smaller
  .github/CODEOWNERS Unsupported file format
  crates/hyperswitch_connectors/src/connectors/coinbase.rs  0% smaller
  crates/hyperswitch_domain_models/src/connector_endpoints.rs  0% smaller
  crates/hyperswitch_domain_models/src/lib.rs  0% smaller
  crates/hyperswitch_domain_models/src/router_request_types/revenue_recovery.rs  0% smaller
  crates/hyperswitch_interfaces/src/api.rs  0% smaller
  crates/hyperswitch_interfaces/src/configs.rs  0% smaller
  crates/hyperswitch_interfaces/src/connector_integration_interface.rs Unsupported file format
  crates/router/src/core/webhooks/recovery_incoming.rs  0% smaller
  crates/router/src/types.rs  0% smaller
  crates/router/src/types/api/connector_mapping.rs  0% smaller
  crates/router/src/types/connector_transformers.rs  0% smaller
  crates/router/src/types/transformers.rs  0% smaller
  scripts/add_connector.sh Unsupported file format

@awasthi21 awasthi21 changed the title Remove framework dep refactor(connector): Move connector mappings and endpoints to dedicated modules Jul 7, 2025
@awasthi21 awasthi21 force-pushed the remove-framework-dep branch from 9a2f2a4 to 474a85b Compare July 7, 2025 05:24
@awasthi21 awasthi21 requested a review from a team as a code owner July 7, 2025 05:58
@awasthi21 awasthi21 force-pushed the remove-framework-dep branch from 4500dc6 to 49a1bdf Compare July 7, 2025 06:45
deepanshu-iiitu
deepanshu-iiitu previously approved these changes Jul 7, 2025
View reviewed changes
@awasthi21 awasthi21 force-pushed the remove-framework-dep branch from f9618b7 to ead9ad5 Compare July 8, 2025 04:35
deepanshu-iiitu
deepanshu-iiitu previously approved these changes Jul 8, 2025
View reviewed changes
SanchithHegde
SanchithHegde reviewed Jul 8, 2025
View reviewed changes
crates/hyperswitch_domain_models/src/connector_endpoints.rs Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit(naming): Could have called this connector configs rather. Optional change.

crates/hyperswitch_interfaces/src/configs.rs Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this module at all? Where is this module (the re-exports from this module) being accessed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its imported in the hyperswitch_connectors crate.
We can also access it directly via the domain model, but isn't it better to access it through the interface?

@awasthi21 awasthi21 force-pushed the remove-framework-dep branch 2 times, most recently from 2378aac to 2545a46 Compare July 8, 2025 11:50
deepanshu-iiitu
deepanshu-iiitu previously approved these changes Jul 8, 2025
View reviewed changes
SanchithHegde
SanchithHegde previously approved these changes Jul 8, 2025
View reviewed changes
@awasthi21 awasthi21 force-pushed the remove-framework-dep branch from a39688c to c02f932 Compare July 8, 2025 13:31
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Jul 9, 2025
Merged via the queue into main with commit 99885b6 Jul 9, 2025
20 of 24 checks passed
@Gnanasundari24 Gnanasundari24 deleted the remove-framework-dep branch July 9, 2025 08:09
pixincreate added a commit that referenced this pull request Jul 9, 2025
@pixincreate
Merge branch 'main' of github.com:juspay/hyperswitch into connector/p…
661fbbe 
…ayload-webhooks

* 'main' of github.com:juspay/hyperswitch:
  refactor(connector): Move connector mappings and endpoints to dedicated modules (#8562)
  ci(cypress): fix `hipay` test cases (#8563)
  chore(version): 2025.07.09.0
  fix(payment_method): update entity id used for Vault to global customer id (#8380)
  refactor(routing): add conditional check for invoking DE routing flows (#8559)
  feat(connector): [AUTHIPAY] Integrate cards non 3ds payments (#8266)
  ci(cypress): add payu connector (#8567)
  feat(connector): [silverflow] template code (#8553)
  chore(version): 2025.07.08.0
  feat(cypress): [worldpayvantiv] add cypress test (#8234)
  feat(connectors): [worldpayvantiv] add connector mandate support  (#8546)
  feat(connector): [Celero] add Connector Template Code (#8489)
  feat(payment-methods): create payment_token in vault confirm / do payment-confirm with temp token from session (#8525)
  ci(cypress): Add Tsys,Square cypress test (#8543)
  chore(version): 2025.07.07.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@deepanshu-iiitu deepanshu-iiitu deepanshu-iiitu approved these changes

@sai-harsha-vardhan sai-harsha-vardhan sai-harsha-vardhan approved these changes

Assignees

@awasthi21 awasthi21

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@awasthi21 @SanchithHegde @deepanshu-iiitu @sai-harsha-vardhan @Gnanasundari24