Skip to content

chore(env): revert wasm changes for payload connector #8818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2025

Conversation

pixincreate
Copy link
Member

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

this pr reverts wasm changes for the payload connector that was introduced in #8597

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

crates/connector_configs/toml/*

Motivation and Context

this change broke wasm.

How did you test it?

image

this shouldn't pop-up during the wasm build.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by just clippy && just clippy_v2
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@pixincreate pixincreate requested a review from a team as a code owner August 1, 2025 09:30
Copy link

Review changes with  SemanticDiff

@pixincreate pixincreate self-assigned this Aug 1, 2025
@pixincreate pixincreate added A-connector-integration Area: Connector integration S-waiting-on-review Status: This PR has been implemented and needs to be reviewed P-high Priority: High labels Aug 1, 2025
@pixincreate pixincreate added this to the July 2025 Release milestone Aug 1, 2025
@pixincreate pixincreate linked an issue Aug 1, 2025 that may be closed by this pull request
@likhinbopanna likhinbopanna added this pull request to the merge queue Aug 1, 2025
Merged via the queue into main with commit e6268d6 Aug 1, 2025
18 of 26 checks passed
@likhinbopanna likhinbopanna deleted the connector/revert-payload-wasm-changes branch August 1, 2025 10:36
@pixincreate pixincreate removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration P-high Priority: High
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Add mandates for Payload
4 participants