refactor(connector): [Nuvei] Fix card 3ds #8913

swangi-kumari · 2025-08-11T14:21:59Z

Type of Change

Description

Fix deserlization error for Nuvei card 3ds

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Create nuvie card 3ds

curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_5iub419oM0WIf9pI6nHrCbopoQ5dSKQEJkyPJZCmYbqECx5KC61S7N1yl7c1IdKD' \
--data-raw '{
    "amount": 15100,
    "currency": "EUR",
    "confirm": true,
    "customer_id":"nithxxinn",
    "return_url": "https://www.google.com",
    "capture_method": "automatic",
    "payment_method": "card",
    "payment_method_type": "credit",
    "authentication_type": "three_ds",
    "description": "hellow world",
    "billing": {
        "address": {
            "zip": "560095",
            "country": "US",
            "first_name": "Sakil",
            "last_name": "Mostak",
            "line1": "Fasdf",
            "line2": "Fasdf",
            "city": "Fasdf"
        }
    },
    "browser_info": {
        "accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,*/*;q=0.8",
        "ip_address": "192.168.1.1",
        "java_enabled": false,
        "java_script_enabled": true,
        "language": "en-US",
        "color_depth": 24,
        "screen_height": 1080,
        "screen_width": 1920,
        "time_zone": 330,
        "user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/114.0.0.0 Safari/537.36"
    },
    "email": "[email protected]",
    "payment_method_data": {
        "card": {
            "card_number": "2221008123677736",
            "card_exp_month": "12",
            "card_exp_year": "2030",
            "card_holder_name": "CL-BRW2",
            "card_cvc": "217"
        }
    },
     "setup_future_usage": "on_session"
}'

response

{
    "payment_id": "pay_SwA17VK0vJc9lZyksSsp",
    "merchant_id": "merchant_1754896786",
    "status": "requires_customer_action",
    "amount": 15100,
    "net_amount": 15100,
    "shipping_cost": null,
    "amount_capturable": 15100,
    "amount_received": null,
    "connector": "nuvei",
    "client_secret": "pay_SwA17VK0vJc9lZyksSsp_secret_1Le4qoHaeDahJN4pDv4N",
    "created": "2025-08-11T12:47:40.099Z",
    "currency": "EUR",
    "customer_id": "nithxxinn",
    "customer": {
        "id": "nithxxinn",
        "name": null,
        "email": "[email protected]",
        "phone": null,
        "phone_country_code": null
    },
    "description": "hellow world",
    "refunds": null,
    "disputes": null,
    "mandate_id": null,
    "mandate_data": null,
    "setup_future_usage": "on_session",
    "off_session": null,
    "capture_on": null,
    "capture_method": "automatic",
    "payment_method": "card",
    "payment_method_data": {
        "card": {
            "last4": "7736",
            "card_type": null,
            "card_network": null,
            "card_issuer": null,
            "card_issuing_country": null,
            "card_isin": "222100",
            "card_extended_bin": null,
            "card_exp_month": "12",
            "card_exp_year": "2030",
            "card_holder_name": "CL-BRW2",
            "payment_checks": {
                "avs_description": null,
                "avs_result_code": "",
                "cvv_2_reply_code": "",
                "cvv_2_description": null,
                "merchant_advice_code": "",
                "merchant_advice_code_description": null
            },
            "authentication_data": {
                "cReq": "eyJ0aHJlZURTU2VydmVyVHJhbnNJRCI6IjZjNzNkZWQ5LTRmMzEtNDNjMS1iYjdmLTEwMDA2YmYyMTBmYiIsImFjc1RyYW5zSUQiOiIzZmRhNGVjYS0xMzI3LTQyZjctOGU2Ny1mYzE4ZDUxNDM0NTIiLCJjaGFsbGVuZ2VXaW5kb3dTaXplIjoiMDUiLCJtZXNzYWdlVHlwZSI6IkNSZXEiLCJtZXNzYWdlVmVyc2lvbiI6IjIuMi4wIn0",
                "flow": "challenge",
                "acsUrl": "https://3dsn.sandbox.safecharge.com/ThreeDSACSEmulatorChallenge/api/ThreeDSACSChallengeController/ChallengePage?eyJub3RpZmljYXRpb25VUkwiOiJodHRwOi8vbG9jYWxob3N0OjgwODAvcGF5bWVudHMvcGF5X1N3QTE3VkswdkpjOWxaeWtzU3NwL21lcmNoYW50XzE3NTQ4OTY3ODYvcmVkaXJlY3QvY29tcGxldGUvbnV2ZWkiLCJ0aHJlZURTU2VydmVyVHJhbnNJRCI6IjZjNzNkZWQ5LTRmMzEtNDNjMS1iYjdmLTEwMDA2YmYyMTBmYiIsImFjc1RyYW5zSUQiOiIzZmRhNGVjYS0xMzI3LTQyZjctOGU2Ny1mYzE4ZDUxNDM0NTIiLCJkc1RyYW5zSUQiOiI3ZGUyY2YxZC00MmYxLTQ1ZWItOGE1Mi02MmQ5Mjk3OWEwOWUiLCJkYXRhIjpudWxsLCJNZXNzYWdlVmVyc2lvbiI6IjIuMi4wIn0=",
                "version": "2.2.0",
                "threeDFlow": "1",
                "decisionReason": "NoPreference",
                "threeDReasonId": "",
                "acquirerDecision": "ExemptionRequest",
                "challengePreferenceReason": "12",
                "isExemptionRequestInAuthentication": "0"
            }
        },
        "billing": null
    },
    "payment_token": "token_jptsctTb26hNYSmaPHom",
    "shipping": null,
    "billing": {
        "address": {
            "city": "Fasdf",
            "country": "US",
            "line1": "Fasdf",
            "line2": "Fasdf",
            "line3": null,
            "zip": "560095",
            "state": null,
            "first_name": "Sakil",
            "last_name": "Mostak",
            "origin_zip": null
        },
        "phone": null,
        "email": null
    },
    "order_details": null,
    "email": "[email protected]",
    "name": null,
    "phone": null,
    "return_url": "https://www.google.com/",
    "authentication_type": "three_ds",
    "statement_descriptor_name": null,
    "statement_descriptor_suffix": null,
    "next_action": {
        "type": "redirect_to_url",
        "redirect_to_url": "http://localhost:8080/payments/redirect/pay_SwA17VK0vJc9lZyksSsp/merchant_1754896786/pay_SwA17VK0vJc9lZyksSsp_1"
    },
    "cancellation_reason": null,
    "error_code": null,
    "error_message": null,
    "unified_code": null,
    "unified_message": null,
    "payment_experience": null,
    "payment_method_type": "credit",
    "connector_label": null,
    "business_country": null,
    "business_label": "default",
    "business_sub_label": null,
    "allowed_payment_method_types": null,
    "ephemeral_key": {
        "customer_id": "nithxxinn",
        "created_at": 1754916460,
        "expires": 1754920060,
        "secret": "epk_00825ca507a647b1a68b6e174af4ad28"
    },
    "manual_retry_allowed": null,
    "connector_transaction_id": "8110000000012074375",
    "frm_message": null,
    "metadata": null,
    "connector_metadata": null,
    "feature_metadata": null,
    "reference_id": "7784849111",
    "payment_link": null,
    "profile_id": "pro_Ff3vG29EedTBVrRtdf20",
    "surcharge_details": null,
    "attempt_count": 1,
    "merchant_decision": null,
    "merchant_connector_id": "mca_vvdYt5E4uXbNvYftGlYf",
    "incremental_authorization_allowed": null,
    "authorization_count": null,
    "incremental_authorizations": null,
    "external_authentication_details": null,
    "external_3ds_authentication_attempted": false,
    "expires_on": "2025-08-11T13:02:40.099Z",
    "fingerprint": null,
    "browser_info": {
        "language": "en-US",
        "time_zone": 330,
        "ip_address": "192.168.1.1",
        "user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/114.0.0.0 Safari/537.36",
        "color_depth": 24,
        "java_enabled": false,
        "screen_width": 1920,
        "accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,*/*;q=0.8",
        "screen_height": 1080,
        "java_script_enabled": true
    },
    "payment_channel": null,
    "payment_method_id": null,
    "network_transaction_id": null,
    "payment_method_status": null,
    "updated": "2025-08-11T12:47:42.875Z",
    "split_payments": null,
    "frm_metadata": null,
    "extended_authorization_applied": null,
    "capture_before": null,
    "merchant_order_reference_id": null,
    "order_tax_amount": null,
    "connector_mandate_id": null,
    "card_discovery": "manual",
    "force_3ds_challenge": false,
    "force_3ds_challenge_trigger": false,
    "issuer_error_code": null,
    "issuer_error_message": null,
    "is_iframe_redirection_enabled": null,
    "whole_connector_response": null,
    "enable_partial_authorization": null
}

Complete payment using redirection

Do psync
Response

{
    "payment_id": "pay_SwA17VK0vJc9lZyksSsp",
    "merchant_id": "merchant_1754896786",
    "status": "succeeded",
    "amount": 15100,
    "net_amount": 15100,
    "shipping_cost": null,
    "amount_capturable": 0,
    "amount_received": 15100,
    "connector": "nuvei",
    "client_secret": "pay_SwA17VK0vJc9lZyksSsp_secret_1Le4qoHaeDahJN4pDv4N",
    "created": "2025-08-11T12:47:40.099Z",
    "currency": "EUR",
    "customer_id": "nithxxinn",
    "customer": {
        "id": "nithxxinn",
        "name": null,
        "email": "[email protected]",
        "phone": null,
        "phone_country_code": null
    },
    "description": "hellow world",
    "refunds": null,
    "disputes": null,
    "mandate_id": null,
    "mandate_data": null,
    "setup_future_usage": "on_session",
    "off_session": null,
    "capture_on": null,
    "capture_method": "automatic",
    "payment_method": "card",
    "payment_method_data": {
        "card": {
            "last4": "7736",
            "card_type": null,
            "card_network": null,
            "card_issuer": null,
            "card_issuing_country": null,
            "card_isin": "222100",
            "card_extended_bin": null,
            "card_exp_month": "12",
            "card_exp_year": "2030",
            "card_holder_name": "CL-BRW2",
            "payment_checks": {
                "avs_description": null,
                "avs_result_code": "",
                "cvv_2_reply_code": "",
                "cvv_2_description": null,
                "merchant_advice_code": "",
                "merchant_advice_code_description": null
            },
            "authentication_data": {
                "flow": "challenge",
                "decisionReason": "NoPreference",
                "acquirerDecision": "ExemptionRequest",
                "challengePreferenceReason": "12"
            }
        },
        "billing": null
    },
    "payment_token": "token_jptsctTb26hNYSmaPHom",
    "shipping": null,
    "billing": {
        "address": {
            "city": "Fasdf",
            "country": "US",
            "line1": "Fasdf",
            "line2": "Fasdf",
            "line3": null,
            "zip": "560095",
            "state": null,
            "first_name": "Sakil",
            "last_name": "Mostak",
            "origin_zip": null
        },
        "phone": null,
        "email": null
    },
    "order_details": null,
    "email": "[email protected]",
    "name": null,
    "phone": null,
    "return_url": "https://www.google.com/",
    "authentication_type": "three_ds",
    "statement_descriptor_name": null,
    "statement_descriptor_suffix": null,
    "next_action": null,
    "cancellation_reason": null,
    "error_code": null,
    "error_message": null,
    "unified_code": null,
    "unified_message": null,
    "payment_experience": null,
    "payment_method_type": "credit",
    "connector_label": null,
    "business_country": null,
    "business_label": "default",
    "business_sub_label": null,
    "allowed_payment_method_types": null,
    "ephemeral_key": null,
    "manual_retry_allowed": false,
    "connector_transaction_id": "8110000000012074525",
    "frm_message": null,
    "metadata": null,
    "connector_metadata": null,
    "feature_metadata": null,
    "reference_id": "7784849111",
    "payment_link": null,
    "profile_id": "pro_Ff3vG29EedTBVrRtdf20",
    "surcharge_details": null,
    "attempt_count": 1,
    "merchant_decision": null,
    "merchant_connector_id": "mca_vvdYt5E4uXbNvYftGlYf",
    "incremental_authorization_allowed": null,
    "authorization_count": null,
    "incremental_authorizations": null,
    "external_authentication_details": null,
    "external_3ds_authentication_attempted": false,
    "expires_on": "2025-08-11T13:02:40.099Z",
    "fingerprint": null,
    "browser_info": {
        "language": "en-US",
        "time_zone": 330,
        "ip_address": "192.168.1.1",
        "user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/114.0.0.0 Safari/537.36",
        "color_depth": 24,
        "java_enabled": false,
        "screen_width": 1920,
        "accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,*/*;q=0.8",
        "screen_height": 1080,
        "java_script_enabled": true
    },
    "payment_channel": null,
    "payment_method_id": null,
    "network_transaction_id": null,
    "payment_method_status": null,
    "updated": "2025-08-11T12:49:18.842Z",
    "split_payments": null,
    "frm_metadata": null,
    "extended_authorization_applied": null,
    "capture_before": null,
    "merchant_order_reference_id": null,
    "order_tax_amount": null,
    "connector_mandate_id": null,
    "card_discovery": "manual",
    "force_3ds_challenge": false,
    "force_3ds_challenge_trigger": false,
    "issuer_error_code": null,
    "issuer_error_message": null,
    "is_iframe_redirection_enabled": null,
    "whole_connector_response": null,
    "enable_partial_authorization": null
}

cypress test

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

semanticdiff-com · 2025-08-11T14:22:02Z

Review changes with

Changed Files

File	Status
crates/hyperswitch_connectors/src/connectors/nuvei/transformers.rs	67% smaller
crates/hyperswitch_domain_models/src/router_request_types/authentication.rs	0% smaller
cypress-tests/cypress/e2e/configs/Payment/Nuvei.js	0% smaller

The base branch was changed.

SanchithHegde · 2025-08-13T15:02:59Z

crates/hyperswitch_connectors/src/connectors/nuvei/transformers.rs

+                    challenge_window_size: Some("05".to_string()),
+                    challenge_preference: Some("01".to_string()),


Why has this been hardcoded?

Nithin1506200 and others added 20 commits July 28, 2025 14:06

Nuvie

4977b42

moto transaction

730c0ac

update

9d9ac94

update

5f92bbb

Merge branch 'main' of https://github.com/juspay/hyperswitch into nuvie

b4d36c4

update

ca9054b

nuvie changes

f3053c9

add nuvie

7987e24

Merge branch 'main' of https://github.com/juspay/hyperswitch into nuvie

75bc591

nuvie

69487f3

Update

feee36c

update

4343d98

update

f4cc259

fix cypress

a93ee75

clippy

eb0be51

update

a805364

update

2e9ec16

Update transformers.rs

9766eda

chore: run formatter

312579b

refactor: card 3ds

83de499

swangi-kumari requested review from a team as code owners August 11, 2025 14:22

swangi-kumari linked an issue Aug 11, 2025 that may be closed by this pull request

[REFACTOR]: [NUVIE] Fix card 3ds #8914

Open

chore: run formatter

bc78388

swangi-kumari self-assigned this Aug 11, 2025

swangi-kumari added A-connector-integration Area: Connector integration C-refactor Category: Refactor labels Aug 11, 2025

swangi-kumari requested a review from a team as a code owner August 12, 2025 07:26

refactor: clippy

f58e1d6

swangi-kumari force-pushed the nuvie-3ds-fix branch from 331d7fc to f58e1d6 Compare August 12, 2025 07:29

swangi-kumari removed the request for review from a team August 12, 2025 07:30

refactor: formatting

e8d50aa

dgeee13 previously approved these changes Aug 12, 2025

View reviewed changes

deepanshu-iiitu approved these changes Aug 12, 2025

View reviewed changes

refactor: cypress

04a64de

swangi-kumari requested a review from a team as a code owner August 12, 2025 11:17

deepanshu-iiitu previously approved these changes Aug 12, 2025

View reviewed changes

Base automatically changed from nuvie to main August 13, 2025 10:27

Merge branch 'main' into nuvie-3ds-fix

af3a6be

swangi-kumari changed the title ~~refactor(connector): [Nuvie] Fix card 3ds~~ refactor(connector): [Nuvei] Fix card 3ds Aug 13, 2025

dgeee13 approved these changes Aug 13, 2025

View reviewed changes

deepanshu-iiitu approved these changes Aug 13, 2025

View reviewed changes

SanchithHegde reviewed Aug 13, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor(connector): [Nuvei] Fix card 3ds #8913

refactor(connector): [Nuvei] Fix card 3ds #8913

Uh oh!

swangi-kumari commented Aug 11, 2025 •

edited

Loading

Uh oh!

semanticdiff-com bot commented Aug 11, 2025 •

edited

Loading

Uh oh!

SanchithHegde Aug 13, 2025

Uh oh!

Uh oh!

		challenge_window_size: Some("05".to_string()),
		challenge_preference: Some("01".to_string()),

refactor(connector): [Nuvei] Fix card 3ds #8913

Are you sure you want to change the base?

refactor(connector): [Nuvei] Fix card 3ds #8913

Uh oh!

Conversation

swangi-kumari commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

Description

Additional Changes

Motivation and Context

How did you test it?

Checklist

Uh oh!

semanticdiff-com bot commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SanchithHegde Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

swangi-kumari commented Aug 11, 2025 •

edited

Loading

semanticdiff-com bot commented Aug 11, 2025 •

edited

Loading