refactor(connector): implement amount converter framework for coinbase, dummyconnector and gocardless #8915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixincreate
added
A-connector-integration
|
Review changes with Changed Files |
pixincreate
changed the title
pixincreate
changed the title
deepanshu-iiitu
approved these changes
Aug 13, 2025
awasthi21
approved these changes
Aug 13, 2025
awasthi21
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
the existing amount conversion framework for certain connector is outdated. we need to migrate those connector to using the latest and greatest amount converter framework.
base - float/string major unit
minor - minor unit / string minor unit
Additional Changes
Motivation and Context
get_currency_unit is outdated. use convert_amount instead.
closes #8877
How did you test it?
Coinbase
{ "payment_id": "pay_CLNI5uKf7oPwBpouxOW7", "merchant_id": "postman_merchant_GHAction_da839d55-615f-45ca-8173-8b2c1ee2450d", "status": "requires_customer_action", "amount": 650, "net_amount": 650, "shipping_cost": null, "amount_capturable": 650, "amount_received": null, "connector": "coinbase", "client_secret": "pay_CLNI5uKf7oPwBpouxOW7_secret_SVuY4GDzZnKanqhta9WT", "created": "2025-08-13T08:47:10.408Z", "currency": "USD", "customer_id": "StripeCustomer", "customer": { "id": "StripeCustomer", "name": "John Doe", "email": "[email protected]", "phone": "999999999", "phone_country_code": "+1" }, "description": "Its my first payment request", "refunds": null, "disputes": null, "mandate_id": null, "mandate_data": null, "setup_future_usage": null, "off_session": null, "capture_on": null, "capture_method": "automatic", "payment_method": "crypto", "payment_method_data": { "crypto": { "pay_currency": null, "network": null }, "billing": null }, "payment_token": null, "shipping": { "address": { "city": "San Fransico", "country": "US", "line1": "1467", "line2": "Harrison Street", "line3": "Harrison Street", "zip": "94122", "state": "California", "first_name": "joseph", "last_name": "Doe", "origin_zip": null }, "phone": { "number": "8056594427", "country_code": "+91" }, "email": null }, "billing": { "address": { "city": "San Fransico", "country": "US", "line1": "1467", "line2": "Harrison Street", "line3": "Harrison Street", "zip": "94122", "state": "California", "first_name": "joseph", "last_name": "Doe", "origin_zip": null }, "phone": { "number": "8056594427", "country_code": "+91" }, "email": null }, "order_details": null, "email": "[email protected]", "name": "John Doe", "phone": "999999999", "return_url": "https://duck.com/", "authentication_type": "no_three_ds", "statement_descriptor_name": "joseph", "statement_descriptor_suffix": "JS", "next_action": { "type": "redirect_to_url", "redirect_to_url": "http://localhost:8080/payments/redirect/pay_CLNI5uKf7oPwBpouxOW7/postman_merchant_GHAction_da839d55-615f-45ca-8173-8b2c1ee2450d/pay_CLNI5uKf7oPwBpouxOW7_1" }, "cancellation_reason": null, "error_code": null, "error_message": null, "unified_code": null, "unified_message": null, "payment_experience": null, "payment_method_type": "crypto_currency", "connector_label": null, "business_country": null, "business_label": "default", "business_sub_label": null, "allowed_payment_method_types": null, "ephemeral_key": { "customer_id": "StripeCustomer", "created_at": 1755074830, "expires": 1755078430, "secret": "epk_ec8855ba7f224bbf9d0dde760cfe8dcf" }, "manual_retry_allowed": null, "connector_transaction_id": "9db49127-2475-492f-9350-27922af302a5", "frm_message": null, "metadata": { "udf1": "value1", "login_date": "2019-09-10T10:11:12Z", "new_customer": "true" }, "connector_metadata": { "apple_pay": null, "airwallex": null, "noon": { "order_category": "applepay" }, "braintree": null, "adyen": null }, "feature_metadata": null, "reference_id": "9db49127-2475-492f-9350-27922af302a5", "payment_link": null, "profile_id": "pro_nrrYrNEsGYdk0dX9vNRw", "surcharge_details": null, "attempt_count": 1, "merchant_decision": null, "merchant_connector_id": "mca_KOTaF0wTjrtYec6h5jzN", "incremental_authorization_allowed": null, "authorization_count": null, "incremental_authorizations": null, "external_authentication_details": null, "external_3ds_authentication_attempted": false, "expires_on": "2025-08-13T09:02:10.408Z", "fingerprint": null, "browser_info": { "language": "nl-NL", "time_zone": 0, "ip_address": "128.0.0.1", "user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36", "color_depth": 24, "java_enabled": true, "screen_width": 1536, "accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8", "screen_height": 723, "java_script_enabled": true }, "payment_channel": null, "payment_method_id": null, "network_transaction_id": null, "payment_method_status": null, "updated": "2025-08-13T08:47:11.188Z", "split_payments": null, "frm_metadata": null, "extended_authorization_applied": null, "capture_before": null, "merchant_order_reference_id": null, "order_tax_amount": null, "connector_mandate_id": null, "card_discovery": null, "force_3ds_challenge": false, "force_3ds_challenge_trigger": false, "issuer_error_code": null, "issuer_error_message": null, "is_iframe_redirection_enabled": null, "whole_connector_response": null, "enable_partial_authorization": null }DummyConnector (PhonyPay)
{ "payment_id": "pay_7ccFxKOV1Fw3Y1rS0Wg7", "merchant_id": "postman_merchant_GHAction_1754996489", "status": "succeeded", "amount": 40, "net_amount": 40, "shipping_cost": null, "amount_capturable": 0, "amount_received": 40, "connector": "phonypay", "client_secret": "pay_7ccFxKOV1Fw3Y1rS0Wg7_secret_Mdgrth3Tau4x7PN2GBT5", "created": "2025-08-12T11:03:14.100Z", "currency": "USD", "customer_id": "customer", "customer": { "id": "customer", "name": null, "email": "[email protected]", "phone": "999999999", "phone_country_code": "+1" }, "description": "Its my first payment request", "refunds": null, "disputes": null, "mandate_id": null, "mandate_data": null, "setup_future_usage": null, "off_session": null, "capture_on": null, "capture_method": "automatic", "payment_method": "card", "payment_method_data": { "card": { "last4": "1111", "card_type": "CREDIT", "card_network": "Visa", "card_issuer": "JP Morgan", "card_issuing_country": "INDIA", "card_isin": "411111", "card_extended_bin": null, "card_exp_month": "10", "card_exp_year": "25", "card_holder_name": "Joseph Doe", "payment_checks": null, "authentication_data": null }, "billing": null }, "payment_token": null, "shipping": { "address": { "city": "San Fransico", "country": "US", "line1": "1467", "line2": "Harrison Street", "line3": "Harrison Street", "zip": "94122", "state": "California", "first_name": "PiX", "last_name": null, "origin_zip": null }, "phone": null, "email": null }, "billing": { "address": { "city": "San Fransico", "country": "US", "line1": "1467", "line2": "Harrison Street", "line3": "Harrison Street", "zip": "94122", "state": "California", "first_name": "PiX", "last_name": "THE", "origin_zip": null }, "phone": null, "email": null }, "order_details": null, "email": "[email protected]", "name": null, "phone": "999999999", "return_url": "https://duck.com/", "authentication_type": "no_three_ds", "statement_descriptor_name": "joseph", "statement_descriptor_suffix": "JS", "next_action": null, "cancellation_reason": null, "error_code": null, "error_message": null, "unified_code": null, "unified_message": null, "payment_experience": null, "payment_method_type": "credit", "connector_label": null, "business_country": null, "business_label": "default", "business_sub_label": null, "allowed_payment_method_types": null, "ephemeral_key": { "customer_id": "customer", "created_at": 1754996594, "expires": 1755000194, "secret": "epk_5c5d052c027543fda6f7857d0b58eabd" }, "manual_retry_allowed": false, "connector_transaction_id": "pay_mhSQIXOGVoHUAFByseO9", "frm_message": null, "metadata": { "udf1": "value1", "login_date": "2019-09-10T10:11:12Z", "new_customer": "true" }, "connector_metadata": null, "feature_metadata": null, "reference_id": null, "payment_link": null, "profile_id": "pro_cO45PqZAnqU4jvOHxs3b", "surcharge_details": null, "attempt_count": 1, "merchant_decision": null, "merchant_connector_id": "mca_082Yi6aV6Rk3lH0XatmN", "incremental_authorization_allowed": null, "authorization_count": null, "incremental_authorizations": null, "external_authentication_details": null, "external_3ds_authentication_attempted": false, "expires_on": "2025-08-12T11:18:14.100Z", "fingerprint": null, "browser_info": { "language": "en-GB", "time_zone": -330, "ip_address": "208.127.127.193", "user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/126.0.0.0 Safari/537.36 Edg/126.0.0.0", "color_depth": 24, "java_enabled": true, "screen_width": 1280, "accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8", "screen_height": 720, "java_script_enabled": true }, "payment_channel": null, "payment_method_id": null, "network_transaction_id": null, "payment_method_status": null, "updated": "2025-08-12T11:03:15.151Z", "split_payments": null, "frm_metadata": null, "extended_authorization_applied": null, "capture_before": null, "merchant_order_reference_id": null, "order_tax_amount": null, "connector_mandate_id": null, "card_discovery": "manual", "force_3ds_challenge": false, "force_3ds_challenge_trigger": false, "issuer_error_code": null, "issuer_error_message": null, "is_iframe_redirection_enabled": null, "whole_connector_response": null, "enable_partial_authorization": null }GoCardless
Intent:
{ "payment_id": "pay_iScvaZkPjMotWE72H3J2", "merchant_id": "postman_merchant_GHAction_966c0a0d-45fc-4342-a264-f5592644bb1d", "status": "requires_payment_method", "amount": 0, "net_amount": 0, "shipping_cost": null, "amount_capturable": 0, "amount_received": null, "connector": null, "client_secret": "pay_iScvaZkPjMotWE72H3J2_secret_HdEL8dGgoTm7Tqs8uz7P", "created": "2025-08-12T10:33:27.540Z", "currency": "USD", "customer_id": "arjun", "customer": { "id": "arjun", "name": null, "email": "[email protected]", "phone": null, "phone_country_code": null }, "description": "Hello this is description", "refunds": null, "disputes": null, "mandate_id": null, "mandate_data": { "update_mandate_id": null, "customer_acceptance": null, "mandate_type": { "multi_use": { "amount": 1000, "currency": "USD", "start_date": null, "end_date": null, "metadata": null } } }, "setup_future_usage": "off_session", "off_session": null, "capture_on": null, "capture_method": "automatic", "payment_method": null, "payment_method_data": null, "payment_token": null, "shipping": { "address": { "city": "Banglore", "country": "US", "line1": "sdsdfsdf", "line2": "hsgdbhd", "line3": "alsksoe", "zip": "571201", "state": "zsaasdas", "first_name": "joseph", "last_name": "doe", "origin_zip": null }, "phone": { "number": "123456789", "country_code": "+1" }, "email": null }, "billing": { "address": { "city": "San Fransico", "country": "US", "line1": "1467", "line2": "Harrison Street", "line3": "Harrison Street", "zip": "94122", "state": "California", "first_name": "joseph", "last_name": "Doe", "origin_zip": null }, "phone": { "number": "8056594427", "country_code": "+91" }, "email": null }, "order_details": null, "email": "[email protected]", "name": null, "phone": null, "return_url": null, "authentication_type": "three_ds", "statement_descriptor_name": null, "statement_descriptor_suffix": null, "next_action": null, "cancellation_reason": null, "error_code": null, "error_message": null, "unified_code": null, "unified_message": null, "payment_experience": null, "payment_method_type": null, "connector_label": null, "business_country": null, "business_label": "default", "business_sub_label": null, "allowed_payment_method_types": null, "ephemeral_key": { "customer_id": "arjun", "created_at": 1754994807, "expires": 1754998407, "secret": "epk_4fa6ae0c645f4c689976ad5a72083808" }, "manual_retry_allowed": null, "connector_transaction_id": null, "frm_message": null, "metadata": {}, "connector_metadata": null, "feature_metadata": null, "reference_id": null, "payment_link": null, "profile_id": "pro_OnhGgkfSOBKAWXPCyIPD", "surcharge_details": null, "attempt_count": 1, "merchant_decision": null, "merchant_connector_id": null, "incremental_authorization_allowed": null, "authorization_count": null, "incremental_authorizations": null, "external_authentication_details": null, "external_3ds_authentication_attempted": false, "expires_on": "2025-08-12T10:48:27.540Z", "fingerprint": null, "browser_info": null, "payment_channel": null, "payment_method_id": null, "network_transaction_id": null, "payment_method_status": null, "updated": "2025-08-12T10:33:27.568Z", "split_payments": null, "frm_metadata": null, "extended_authorization_applied": null, "capture_before": null, "merchant_order_reference_id": null, "order_tax_amount": null, "connector_mandate_id": null, "card_discovery": null, "force_3ds_challenge": false, "force_3ds_challenge_trigger": false, "issuer_error_code": null, "issuer_error_message": null, "is_iframe_redirection_enabled": null, "whole_connector_response": null, "enable_partial_authorization": null }Confirm:
{ "payment_id": "pay_iScvaZkPjMotWE72H3J2", "merchant_id": "postman_merchant_GHAction_966c0a0d-45fc-4342-a264-f5592644bb1d", "status": "succeeded", "amount": 0, "net_amount": 0, "shipping_cost": null, "amount_capturable": 0, "amount_received": null, "connector": "gocardless", "client_secret": "pay_iScvaZkPjMotWE72H3J2_secret_HdEL8dGgoTm7Tqs8uz7P", "created": "2025-08-12T10:33:27.540Z", "currency": "USD", "customer_id": "arjun", "customer": { "id": "arjun", "name": null, "email": "[email protected]", "phone": null, "phone_country_code": null }, "description": "Hello this is description", "refunds": null, "disputes": null, "mandate_id": "man_TxfmzwCyOWnkaOJLD8uZ", "mandate_data": { "update_mandate_id": null, "customer_acceptance": { "acceptance_type": "online", "accepted_at": "2023-12-07T12:16:08.622Z", "online": { "ip_address": "::1", "user_agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/119.0.0.0 Safari/537.36" } }, "mandate_type": { "multi_use": { "amount": 1000, "currency": "USD", "start_date": null, "end_date": null, "metadata": null } } }, "setup_future_usage": "off_session", "off_session": null, "capture_on": null, "capture_method": "automatic", "payment_method": "bank_debit", "payment_method_data": { "bank_debit": { "ach": { "account_number": "*******3358", "routing_number": "026***150", "card_holder_name": null, "bank_account_holder_name": "tests tests", "bank_name": null, "bank_type": "checking", "bank_holder_type": null } }, "billing": null }, "payment_token": null, "shipping": { "address": { "city": "Banglore", "country": "US", "line1": "sdsdfsdf", "line2": "hsgdbhd", "line3": "alsksoe", "zip": "571201", "state": "zsaasdas", "first_name": "joseph", "last_name": "doe", "origin_zip": null }, "phone": { "number": "123456789", "country_code": "+1" }, "email": null }, "billing": { "address": { "city": "San Fransico", "country": "US", "line1": "1467", "line2": "Harrison Street", "line3": "Harrison Street", "zip": "94122", "state": "California", "first_name": "joseph", "last_name": "Doe", "origin_zip": null }, "phone": { "number": "8056594427", "country_code": "+91" }, "email": null }, "order_details": null, "email": "[email protected]", "name": null, "phone": null, "return_url": "https://duck.com/completion", "authentication_type": "three_ds", "statement_descriptor_name": null, "statement_descriptor_suffix": null, "next_action": null, "cancellation_reason": null, "error_code": null, "error_message": null, "unified_code": null, "unified_message": null, "payment_experience": null, "payment_method_type": "ach", "connector_label": null, "business_country": null, "business_label": "default", "business_sub_label": null, "allowed_payment_method_types": null, "ephemeral_key": null, "manual_retry_allowed": false, "connector_transaction_id": null, "frm_message": null, "metadata": {}, "connector_metadata": null, "feature_metadata": null, "reference_id": null, "payment_link": null, "profile_id": "pro_OnhGgkfSOBKAWXPCyIPD", "surcharge_details": null, "attempt_count": 1, "merchant_decision": null, "merchant_connector_id": "mca_MiDByOyz51vpnOHVrF1G", "incremental_authorization_allowed": null, "authorization_count": null, "incremental_authorizations": null, "external_authentication_details": null, "external_3ds_authentication_attempted": false, "expires_on": "2025-08-12T10:48:27.540Z", "fingerprint": null, "browser_info": { "os_type": null, "language": "en-GB", "time_zone": -330, "ip_address": "0.0.0.0", "os_version": null, "user_agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/119.0.0.0 Safari/537.36", "color_depth": 24, "device_model": null, "java_enabled": true, "screen_width": 2560, "accept_header": "text\/html,application\/xhtml+xml,application\/xml;q=0.9,image\/webp,image\/apng,*\/*;q=0.8", "screen_height": 1440, "accept_language": "en", "java_script_enabled": true }, "payment_channel": null, "payment_method_id": "pm_4QOeVz4wx5SO9j68yN9D", "network_transaction_id": null, "payment_method_status": "active", "updated": "2025-08-12T10:33:32.724Z", "split_payments": null, "frm_metadata": null, "extended_authorization_applied": null, "capture_before": null, "merchant_order_reference_id": null, "order_tax_amount": null, "connector_mandate_id": "MD01K2EXF9H2PY3AA028PJX23E0T", "card_discovery": null, "force_3ds_challenge": false, "force_3ds_challenge_trigger": false, "issuer_error_code": null, "issuer_error_message": null, "is_iframe_redirection_enabled": null, "whole_connector_response": null, "enable_partial_authorization": null }Recurring:
{ "payment_id": "pay_lDdcUJa6ZfVPjQdnBZAk", "merchant_id": "postman_merchant_GHAction_966c0a0d-45fc-4342-a264-f5592644bb1d", "status": "processing", "amount": 499, "net_amount": 499, "shipping_cost": null, "amount_capturable": 499, "amount_received": null, "connector": "gocardless", "client_secret": "pay_lDdcUJa6ZfVPjQdnBZAk_secret_YPsvvAFQutsJaGVFefvg", "created": "2025-08-12T10:34:49.349Z", "currency": "USD", "customer_id": "arjun", "customer": { "id": "arjun", "name": null, "email": "[email protected]", "phone": null, "phone_country_code": null }, "description": null, "refunds": null, "disputes": null, "mandate_id": null, "mandate_data": null, "setup_future_usage": null, "off_session": true, "capture_on": null, "capture_method": "automatic", "payment_method": "bank_debit", "payment_method_data": null, "payment_token": null, "shipping": null, "billing": null, "order_details": null, "email": "[email protected]", "name": null, "phone": null, "return_url": null, "authentication_type": "no_three_ds", "statement_descriptor_name": null, "statement_descriptor_suffix": null, "next_action": null, "cancellation_reason": null, "error_code": null, "error_message": null, "unified_code": null, "unified_message": null, "payment_experience": null, "payment_method_type": "ach", "connector_label": null, "business_country": null, "business_label": "default", "business_sub_label": null, "allowed_payment_method_types": null, "ephemeral_key": { "customer_id": "arjun", "created_at": 1754994889, "expires": 1754998489, "secret": "epk_ea150cc2e9e741038c9146944d272dba" }, "manual_retry_allowed": false, "connector_transaction_id": "PM01K2EXHMYHWGSTD2TRAK0CYFCE", "frm_message": null, "metadata": null, "connector_metadata": null, "feature_metadata": null, "reference_id": null, "payment_link": null, "profile_id": "pro_OnhGgkfSOBKAWXPCyIPD", "surcharge_details": null, "attempt_count": 1, "merchant_decision": null, "merchant_connector_id": "mca_MiDByOyz51vpnOHVrF1G", "incremental_authorization_allowed": null, "authorization_count": null, "incremental_authorizations": null, "external_authentication_details": null, "external_3ds_authentication_attempted": false, "expires_on": "2025-08-12T10:49:49.349Z", "fingerprint": null, "browser_info": null, "payment_channel": null, "payment_method_id": "pm_4QOeVz4wx5SO9j68yN9D", "network_transaction_id": null, "payment_method_status": "active", "updated": "2025-08-12T10:34:49.953Z", "split_payments": null, "frm_metadata": null, "extended_authorization_applied": null, "capture_before": null, "merchant_order_reference_id": null, "order_tax_amount": null, "connector_mandate_id": "MD01K2EXF9H2PY3AA028PJX23E0T", "card_discovery": null, "force_3ds_challenge": false, "force_3ds_challenge_trigger": false, "issuer_error_code": null, "issuer_error_message": null, "is_iframe_redirection_enabled": null, "whole_connector_response": null, "enable_partial_authorization": null }Refunds should work too!
{ "refund_id": "ref_ns4BEGOnyDUr6KSapqgg", "payment_id": "pay_7ccFxKOV1Fw3Y1rS0Wg7", "amount": 35, "currency": "USD", "status": "succeeded", "reason": "Customer returned product", "metadata": { "udf1": "value1", "new_customer": "true", "login_date": "2019-09-10T10:11:12Z" }, "error_message": null, "error_code": null, "unified_code": null, "unified_message": null, "created_at": "2025-08-12T11:04:21.944Z", "updated_at": "2025-08-12T11:04:22.993Z", "connector": "phonypay", "profile_id": "pro_cO45PqZAnqU4jvOHxs3b", "merchant_connector_id": "mca_082Yi6aV6Rk3lH0XatmN", "split_refunds": null, "issuer_error_code": null, "issuer_error_message": null }Checklist
cargo +nightly fmt --alljust clippy && just clippy_v2