Skip to content

feat(payment-link): update traditional chinese local #8935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2025

Conversation

mrudulvajpayee4935
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

We need to update traditional chinese locale for payment link expired.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Raised by the merchant to update the locale to the correct one as shared by them.

How did you test it?

use below curl for payment link create and wait for 60 secs for payment link to get expired:

curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: ***' \
--header 'Accept-Language: zh-Hant' \
--data '{
    "amount": 10,
    "setup_future_usage": "off_session",
    "currency": "EUR",
    "payment_link": true,
    "session_expiry": 60,
    "return_url": "https://google.com",
    "payment_link_config": {
        "theme": "#14356f",
        "logo": "https://logo.com/wp-content/uploads/2020/08/zurich.svg",
        "seller_name": "Zurich Inc."
    }
}'
image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

Copy link

semanticdiff-com bot commented Aug 12, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/core/payment_link/locale.js  0% smaller

@mrudulvajpayee4935 mrudulvajpayee4935 linked an issue Aug 12, 2025 that may be closed by this pull request
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Aug 13, 2025
Merged via the queue into main with commit da6a33d Aug 13, 2025
21 of 29 checks passed
@Gnanasundari24 Gnanasundari24 deleted the update-tradtional-chinese-locale branch August 13, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update traditional chinese locale for payent link expired
4 participants