Skip to content

chore: include missing drop null constraint queries in v2_compatible_migrations #8940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: include missing drop null constraint queries in v2_compatible_migrations #8940

wants to merge 2 commits into from

Conversation

hrithikesh026
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Two drop null constraint queries were missing in v2_compatible_migrations directory. Added those.

  1. Dropping not null on confirm column in payment_attempt.
  2. Dropping not null on internal_reference_id in refunds.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Manual.

Ran just migrate_v2_compatible and then just migrate_v2
image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@hrithikesh026 hrithikesh026 self-assigned this Aug 13, 2025
@hrithikesh026 hrithikesh026 requested a review from a team as a code owner August 13, 2025 12:44
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@hrithikesh026 hrithikesh026 requested a review from a team as a code owner August 13, 2025 13:11
@hrithikesh026 hrithikesh026 added M-database-changes Metadata: This PR involves database schema changes S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Aug 13, 2025
@hyperswitch-bot hyperswitch-bot bot removed the M-database-changes Metadata: This PR involves database schema changes label Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@jarnura jarnura Awaiting requested review from jarnura

At least 2 approving reviews are required to merge this pull request.

Assignees

@hrithikesh026 hrithikesh026

Labels
S-waiting-on-review Status: This PR has been implemented and needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hrithikesh026 @SanchithHegde