fix(connector): update required fields for xendit #8941
Merged
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixincreate
added
A-connector-integration
|
Review changes with Changed Files
|
awasthi21
approved these changes
Aug 13, 2025
awasthi21
approved these changes
Aug 13, 2025
Sakilmostak
approved these changes
Aug 13, 2025
deepanshu-iiitu
approved these changes
Aug 13, 2025
pixincreate
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
this pr addresses an issue where hyperswitch sdk did not return required fields resulting in transactions to not happen.
Additional Changes
Motivation and Context
How did you test it?
Initiate Payment Link
{ "payment_id": "pay_eTNUFfS27ZBvBiTIOalZ", "merchant_id": "postman_merchant_GHAction_1755084978", "status": "requires_payment_method", "amount": 1001200, "net_amount": 1001200, "shipping_cost": null, "amount_capturable": 0, "amount_received": null, "connector": null, "client_secret": "pay_eTNUFfS27ZBvBiTIOalZ_secret_wzOFZMbwSWLLvc6O7rzx", "created": "2025-08-13T12:28:02.711Z", "currency": "IDR", "customer_id": "customer", "customer": { "id": "customer", "name": null, "email": "[email protected]", "phone": "999999999", "phone_country_code": "+1" }, "description": "Its my first payment request", "refunds": null, "disputes": null, "mandate_id": null, "mandate_data": null, "setup_future_usage": null, "off_session": null, "capture_on": null, "capture_method": "automatic", "payment_method": null, "payment_method_data": null, "payment_token": null, "shipping": null, "billing": null, "order_details": null, "email": "[email protected]", "name": null, "phone": "999999999", "return_url": "https://duck.com/", "authentication_type": "no_three_ds", "statement_descriptor_name": "joseph", "statement_descriptor_suffix": "JS", "next_action": null, "cancellation_reason": null, "error_code": null, "error_message": null, "unified_code": null, "unified_message": null, "payment_experience": null, "payment_method_type": null, "connector_label": null, "business_country": null, "business_label": "default", "business_sub_label": null, "allowed_payment_method_types": null, "ephemeral_key": { "customer_id": "customer", "created_at": 1755088082, "expires": 1755091682, "secret": "epk_c63e165ddae2420e975cb21b0f9f894b" }, "manual_retry_allowed": null, "connector_transaction_id": null, "frm_message": null, "metadata": { "udf1": "value1", "login_date": "2019-09-10T10:11:12Z", "new_customer": "true" }, "connector_metadata": null, "feature_metadata": null, "reference_id": null, "payment_link": { "link": "http://localhost:8080/payment_link/postman_merchant_GHAction_1755084978/pay_eTNUFfS27ZBvBiTIOalZ?locale=en", "secure_link": "http://localhost:8080/payment_link/s/postman_merchant_GHAction_1755084978/pay_eTNUFfS27ZBvBiTIOalZ?locale=en", "payment_link_id": "plink_JesEx1Pk1rYTlkh2Zr8f" }, "profile_id": "pro_Xq3nbFTRwHDP9JFgz2w0", "surcharge_details": null, "attempt_count": 1, "merchant_decision": null, "merchant_connector_id": null, "incremental_authorization_allowed": null, "authorization_count": null, "incremental_authorizations": null, "external_authentication_details": null, "external_3ds_authentication_attempted": false, "expires_on": "2025-08-13T12:43:02.708Z", "fingerprint": null, "browser_info": null, "payment_channel": null, "payment_method_id": null, "network_transaction_id": null, "payment_method_status": null, "updated": "2025-08-13T12:28:02.725Z", "split_payments": null, "frm_metadata": null, "extended_authorization_applied": null, "capture_before": null, "merchant_order_reference_id": null, "order_tax_amount": null, "connector_mandate_id": null, "card_discovery": null, "force_3ds_challenge": false, "force_3ds_challenge_trigger": false, "issuer_error_code": null, "issuer_error_message": null, "is_iframe_redirection_enabled": null, "whole_connector_response": null, "enable_partial_authorization": null }Open Payment link
Payment Retrieve
{ "payment_id": "pay_eTNUFfS27ZBvBiTIOalZ", "merchant_id": "postman_merchant_GHAction_1755084978", "status": "succeeded", "amount": 1001200, "net_amount": 1001200, "shipping_cost": null, "amount_capturable": 0, "amount_received": 1001200, "connector": "xendit", "client_secret": "pay_eTNUFfS27ZBvBiTIOalZ_secret_wzOFZMbwSWLLvc6O7rzx", "created": "2025-08-13T12:28:02.711Z", "currency": "IDR", "customer_id": "customer", "customer": { "id": "customer", "name": null, "email": "[email protected]", "phone": "999999999", "phone_country_code": "+1" }, "description": "Its my first payment request", "refunds": null, "disputes": null, "mandate_id": null, "mandate_data": null, "setup_future_usage": null, "off_session": null, "capture_on": null, "capture_method": "automatic", "payment_method": "card", "payment_method_data": { "card": { "last4": "1111", "card_type": "CREDIT", "card_network": "Visa", "card_issuer": "JP Morgan", "card_issuing_country": "INDIA", "card_isin": "411111", "card_extended_bin": null, "card_exp_month": "12", "card_exp_year": "2034", "card_holder_name": "champa lal", "payment_checks": null, "authentication_data": null }, "billing": { "address": { "city": null, "country": null, "line1": null, "line2": null, "line3": null, "zip": null, "state": null, "first_name": "champa", "last_name": "lal", "origin_zip": null }, "phone": { "number": "9123456789", "country_code": "+93" }, "email": "[email protected]" } }, "payment_token": null, "shipping": null, "billing": null, "order_details": null, "email": "[email protected]", "name": null, "phone": "999999999", "return_url": "https://duck.com/", "authentication_type": "no_three_ds", "statement_descriptor_name": "joseph", "statement_descriptor_suffix": "JS", "next_action": null, "cancellation_reason": null, "error_code": null, "error_message": null, "unified_code": null, "unified_message": null, "payment_experience": null, "payment_method_type": "credit", "connector_label": null, "business_country": null, "business_label": "default", "business_sub_label": null, "allowed_payment_method_types": null, "ephemeral_key": null, "manual_retry_allowed": false, "connector_transaction_id": "pr-1a099d71-0f2f-4dd5-979b-dcb04d577fe4", "frm_message": null, "metadata": { "udf1": "value1", "login_date": "2019-09-10T10:11:12Z", "new_customer": "true" }, "connector_metadata": null, "feature_metadata": { "redirect_response": null, "search_tags": null, "apple_pay_recurring_details": null, "gateway_system": "direct" }, "reference_id": "adee5a45-0856-4a35-a8b9-64f589a4f776", "payment_link": { "link": "http://localhost:8080/payment_link/postman_merchant_GHAction_1755084978/pay_eTNUFfS27ZBvBiTIOalZ?locale=en", "secure_link": "http://localhost:8080/payment_link/s/postman_merchant_GHAction_1755084978/pay_eTNUFfS27ZBvBiTIOalZ?locale=en", "payment_link_id": "plink_JesEx1Pk1rYTlkh2Zr8f" }, "profile_id": "pro_Xq3nbFTRwHDP9JFgz2w0", "surcharge_details": null, "attempt_count": 1, "merchant_decision": null, "merchant_connector_id": "mca_uvxifwBKb8ywNkz1sqHV", "incremental_authorization_allowed": false, "authorization_count": null, "incremental_authorizations": null, "external_authentication_details": null, "external_3ds_authentication_attempted": false, "expires_on": "2025-08-13T12:43:02.708Z", "fingerprint": null, "browser_info": { "os_type": "macOS", "language": "en-US", "time_zone": -330, "ip_address": "127.0.0.1", "os_version": "10.15", "user_agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:141.0) Gecko/20100101 Firefox/141.0", "color_depth": 24, "device_model": "Macintosh", "java_enabled": true, "screen_width": 1728, "accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8", "screen_height": 1117, "accept_language": "en-US,en;q=0.5", "java_script_enabled": true }, "payment_channel": null, "payment_method_id": null, "network_transaction_id": null, "payment_method_status": null, "updated": "2025-08-13T12:32:03.344Z", "split_payments": null, "frm_metadata": null, "extended_authorization_applied": null, "capture_before": null, "merchant_order_reference_id": null, "order_tax_amount": null, "connector_mandate_id": null, "card_discovery": "manual", "force_3ds_challenge": false, "force_3ds_challenge_trigger": false, "issuer_error_code": null, "issuer_error_message": null, "is_iframe_redirection_enabled": null, "whole_connector_response": null, "enable_partial_authorization": null }Note
DO NOTE THAT, FOR XENDIT, PASSING
00AT LSB IS MANDATORY WITHOUT WHICH PAYMENT FAILS. THIS HAPPENS TO BE AN ISSUE FROM XENDIT THEMSELVES.Checklist
cargo +nightly fmt --alljust clippy && just clippy_v2