Skip to content

feat(connector): [Gigadat] Implement interac payouts#9566

Merged
likhinbopanna merged 10 commits into
mainfrom
gigadat-payout
Oct 1, 2025
Merged

feat(connector): [Gigadat] Implement interac payouts#9566
likhinbopanna merged 10 commits into
mainfrom
gigadat-payout

Conversation

@swangi-kumari

@swangi-kumari swangi-kumari commented Sep 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Implement Interac payouts

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Not tested as we don't have creds

Checklis

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@swangi-kumari swangi-kumari requested review from a team as code owners September 25, 2025 13:39
@semanticdiff-com

semanticdiff-com Bot commented Sep 25, 2025 •
edited
Loading

Copy link
Copy Markdown

Review changes with  SemanticDiff

Changed Files
File Status
  crates/hyperswitch_connectors/src/default_implementations.rs  21% smaller
  crates/hyperswitch_connectors/src/connectors/gigadat/transformers.rs  2% smaller
  api-reference/v1/openapi_spec_v1.json  0% smaller
  api-reference/v2/openapi_spec_v2.json  0% smaller
  crates/api_models/src/enums.rs  0% smaller
  crates/api_models/src/payments.rs  0% smaller
  crates/api_models/src/payouts.rs  0% smaller
  crates/connector_configs/src/connector.rs  0% smaller
  crates/connector_configs/toml/development.toml Unsupported file format
  crates/connector_configs/toml/production.toml Unsupported file format
  crates/connector_configs/toml/sandbox.toml Unsupported file format
  crates/hyperswitch_connectors/src/connectors/gigadat.rs  0% smaller
  crates/hyperswitch_connectors/src/utils.rs  0% smaller
  crates/hyperswitch_domain_models/src/router_request_types.rs  0% smaller
  crates/router/src/core/payouts.rs  0% smaller
  crates/router/src/core/utils.rs  0% smaller
  crates/router/tests/connectors/utils.rs  0% smaller

@swangi-kumari swangi-kumari self-assigned this Sep 25, 2025
@swangi-kumari swangi-kumari linked an issue Sep 25, 2025 that may be closed by this pull request
[FEATURE]: [GIGADAT] Implement Interac payouts #9567
Closed
@swangi-kumari swangi-kumari added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement labels Sep 25, 2025
@hyperswitch-bot hyperswitch-bot Bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Sep 26, 2025
Sakilmostak
Sakilmostak requested changes Sep 26, 2025
View reviewed changes
Comment thread crates/api_models/src/payouts.rs

/// Additional details required by 3DS 2.0
#[schema(value_type = Option<BrowserInformation>)]
pub browser_info: Option<BrowserInformation>,

@Sakilmostak Sakilmostak Sep 26, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do inplace import for readability

Suggested change
pub browser_info: Option<BrowserInformation>,
#[cfg(feature = "v1")]
pub browser_info: Option<payments::BrowserInformation>,
#[cfg(feature = "v2")]
pub browser_info: Option<common_utils::types::BrowserInformation>,

@swangi-kumari swangi-kumari Sep 26, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are avoiding feature flags on fields as much as possible , instead keep them on top-level imports
cc- @sai-harsha-vardhan

Comment thread crates/hyperswitch_connectors/src/connectors/gigadat/transformers.rs Outdated
}
}

#[derive(Debug, Serialize, PartialEq)]

@Sakilmostak Sakilmostak Sep 26, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need PartialEq?

Comment thread crates/hyperswitch_connectors/src/connectors/gigadat/transformers.rs Outdated
}
}

#[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]

@Sakilmostak Sakilmostak Sep 26, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Comment thread crates/hyperswitch_connectors/src/connectors/gigadat/transformers.rs Outdated
pub data: GigadatPayoutData,
}

#[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]

@Sakilmostak Sakilmostak Sep 26, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Comment thread crates/hyperswitch_connectors/src/connectors/gigadat/transformers.rs Outdated
}
}

#[derive(Default, Debug, Serialize, Deserialize, PartialEq)]

@Sakilmostak Sakilmostak Sep 26, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@Sakilmostak Sakilmostak Sep 26, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove redundant derive macros wherever present

Comment thread crates/connector_configs/toml/development.toml Outdated
[gigadat_payout.connector_auth.SignatureKey]
api_key = "Username"
api_secret = "Password"
key1 = "Compaign Id"

@Sakilmostak Sakilmostak Sep 26, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it Campaign Id?

Comment thread crates/connector_configs/toml/production.toml Outdated
[gigadat_payout.connector_auth.SignatureKey]
api_key = "Username"
api_secret = "Password"
key1 = "Compaign Id"

@Sakilmostak Sakilmostak Sep 26, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Comment thread crates/connector_configs/toml/sandbox.toml Outdated
[gigadat_payout.connector_auth.SignatureKey]
api_key = "Username"
api_secret = "Password"
key1 = "Compaign Id"

@Sakilmostak Sakilmostak Sep 26, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Sakilmostak
Sakilmostak previously approved these changes Sep 26, 2025
View reviewed changes
AkshayaFoiger
AkshayaFoiger previously approved these changes Sep 26, 2025
View reviewed changes
@likhinbopanna likhinbopanna added this pull request to the merge queue Sep 26, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Sep 26, 2025
AkshayaFoiger
AkshayaFoiger previously approved these changes Sep 28, 2025
View reviewed changes
Sakilmostak
Sakilmostak previously approved these changes Sep 29, 2025
View reviewed changes
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Sep 29, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Sep 29, 2025
@likhinbopanna likhinbopanna added this pull request to the merge queue Sep 30, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Sep 30, 2025
AkshayaFoiger
AkshayaFoiger previously approved these changes Sep 30, 2025
View reviewed changes
Sakilmostak
Sakilmostak previously approved these changes Sep 30, 2025
View reviewed changes
@likhinbopanna likhinbopanna added this pull request to the merge queue Oct 1, 2025
Merged via the queue into main with commit cf30da2 Oct 1, 2025
21 of 25 checks passed
@likhinbopanna likhinbopanna deleted the gigadat-payout branch October 1, 2025 09:32
@Gnanasundari24 Gnanasundari24 added the Alpha This is an Alpha integration , code generated and tested by mock server , not on sandbox API's label Oct 7, 2025
@swangi-kumari swangi-kumari mentioned this pull request Oct 17, 2025
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sai-harsha-vardhan sai-harsha-vardhan sai-harsha-vardhan approved these changes

@Sakilmostak Sakilmostak Sakilmostak approved these changes

@AkshayaFoiger AkshayaFoiger AkshayaFoiger approved these changes

Assignees

@swangi-kumari swangi-kumari

Labels

A-connector-integration Area: Connector integration Alpha This is an Alpha integration , code generated and tested by mock server , not on sandbox API's C-feature Category: Feature request or enhancement M-api-contract-changes Metadata: This PR involves API contract changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE]: [GIGADAT] Implement Interac payouts

6 participants

@swangi-kumari @sai-harsha-vardhan @Sakilmostak @AkshayaFoiger @Gnanasundari24 @likhinbopanna