Skip to content

Conversation

@tumb1er
Copy link
Contributor

@tumb1er tumb1er commented Apr 7, 2020

The problem with overriden AssetType model is that migration dependency is broken:

  • formats data migration in image_assets must be applied before deletion of format field in assets
  • formats field must be applied after adding formats field in assets

While first dependency could be established in assets migration, second dependency belongs to image_assets library and could not be set up properly.
The solution is to disable data migration for abstract AssetType model in favor of copying this migration to an assets application.

@tumb1er tumb1er requested a review from ttyS15 April 7, 2020 10:56
@tumb1er tumb1er self-assigned this Apr 7, 2020
@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #35 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #35   +/-   ##
=======================================
  Coverage   97.85%   97.85%           
=======================================
  Files          24       24           
  Lines         652      653    +1     
=======================================
+ Hits          638      639    +1     
  Misses         14       14           
Flag Coverage Δ
#unittests 97.85% <100.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
image_assets/migrations/0006_migrate_formats.py 76.92% <100.00%> (+1.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc6aa01...181c687. Read the comment docs.

@tumb1er tumb1er merged commit c85ae52 into just-work:master Apr 7, 2020
@tumb1er tumb1er deleted the fix_data_migration branch April 7, 2020 12:02
@tumb1er tumb1er added this to the 0.0.13 milestone Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant