Fixed issue #369#373
Merged
justadudewhohacks merged 3 commits intoAug 6, 2018
Merged
Conversation
…if object is not found rather than always returning a Rect
Contributor
Author
|
@justadudewhohacks, some CI tests failed, but none of them are related to the change. |
Owner
|
Thanks for the PR! Travis is complaining about: |
…if object is not found rather than always returning a Rect
Contributor
Author
|
Done. I've replaced with FF_RETURN(Nan::Null()) |
justadudewhohacks
approved these changes
Aug 6, 2018
Owner
|
Thanks! Published your changes to npm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracker.update() now returns NULL if object is not found rather than always returning a Rect