Skip to content

Fixed issue #369#373

Merged
justadudewhohacks merged 3 commits into
justadudewhohacks:masterfrom
raphaelbarreto:master
Aug 6, 2018
Merged

Fixed issue #369#373
justadudewhohacks merged 3 commits into
justadudewhohacks:masterfrom
raphaelbarreto:master

Conversation

@raphaelbarreto

Copy link
Copy Markdown
Contributor

Tracker.update() now returns NULL if object is not found rather than always returning a Rect

…if object is not found rather than always returning a Rect
@raphaelbarreto

Copy link
Copy Markdown
Contributor Author

@justadudewhohacks, some CI tests failed, but none of them are related to the change.

@justadudewhohacks

Copy link
Copy Markdown
Owner

Thanks for the PR! Travis is complaining about: error: call of overloaded 'Set(NULL)' is ambiguous #define FF_RETURN(val) info.GetReturnValue().Set(val). I think it's better to return FF_RETURN(Nan::Undefined()) or FF_RETURN(Nan::Null()) instead of FF_RETURN(NULL).

@raphaelbarreto

Copy link
Copy Markdown
Contributor Author

Done. I've replaced with FF_RETURN(Nan::Null())

@justadudewhohacks justadudewhohacks merged commit 308d1d9 into justadudewhohacks:master Aug 6, 2018
@justadudewhohacks

Copy link
Copy Markdown
Owner

Thanks! Published your changes to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants