Add cv.seamlessClone#614
Conversation
|
Thanks for the PR! In general looks good to me. If you could refactor the worker to use the new CvClassMethodBinding as GaussianBlur does for example, that would be great! This also allows you to simply export this method as a class method as well as a global method, as described in the contribution guide. As you figured out, there are no MatPhotoBindings files yet, but you can simply add them. |
…eamlessClone`, add `seamlessClone` bindings for `Mat`
|
Thanks for the quick and detailed feedback! I've made the changes as suggested - let me know if you'd like to see additional tests or have any other feedback before merge! |
|
Perfect thanks! Since you now added the class binding, could you also add the seamlessClone typings to Mat.d.ts. After that it's ready to merge. :) |
|
Thanks - I knew I forgot something...! All done. |
|
Awesome! |
This pull request adds bindings for
seamlessClone.I'm on the fence whether this should also exist as a class method of
cv::Mator only as a global function. This pull request only implements the latter, due to:photonamespace do not have anycv::MatbindingsseamlessClonetakes multiplecv::Matas input parameters and it would be confusing to figure out which one is being passed in.Would appreciate your direction on whether class method bindings are also necessary - I'd be happy to add them if so.
Also let me know if you'd prefer additional tests.