Skip to content

feat: sign with apple #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 3, 2024
Merged

feat: sign with apple #192

merged 2 commits into from
Aug 3, 2024

Conversation

G-XD
Copy link
Contributor

@G-XD G-XD commented Jan 19, 2024

  1. support sign with apple
  2. refactor checkConfig logic of AuthDefaultRequest

I tested it locally, but I didn't submit the test case code due to key privacy issues.

@G-XD
Copy link
Contributor Author

G-XD commented Feb 1, 2024

cc @zhangyd-c

@zhangyd-c
Copy link
Member

Thanks, this feature is great!

but, please submit this pr to the dev branch.

@zhangyd-c zhangyd-c merged commit 2ee2483 into justauth:master Aug 3, 2024
@zhangyd-c zhangyd-c mentioned this pull request Aug 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@G-XD @zhangyd-c