This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Fix build with Clang #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forward declarations are not allowed to have nested namespace declarations, as they have to appear inside a namespace if the thing they're forwarding appears in a namespace originally. This is a warning with GCC, but an error with Clang. Removing the declaration entirely is the way to go, since psgStreamReader.h includes textSubtitles.h anyway, which contains a full definition of the TextToPGSConverter class.
Owner
|
This is great, I've been struggling with getting a build going with osxcross and that also requires Clang. Can you please test your build for the issues given the in other active issue, around errors with 64 bit? Preferably using the same files in the Google Drive. I'm curious if you see the exact same corruption issues. |
Contributor
Author
|
I left a comment in #9. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward declarations are not allowed to have nested namespace declarations, as
they have to appear inside a namespace if the thing they're forwarding appears
in a namespace originally.
This is a warning with GCC, but an error with Clang. Removing the declaration
entirely is the way to go, since psgStreamReader.h includes textSubtitles.h
anyway, which contains a full definition of the TextToPGSConverter class.