Skip to content
This repository was archived by the owner on Apr 21, 2025. It is now read-only.

Conversation

@justdan96
Copy link
Owner

Please note this will mean current subtitle font family settings saved in your configuration would be lost.

…his will mean current subtitle font family settings saved in your configuration would be lost.
@justdan96 justdan96 added the enhancement New feature or request label Jan 8, 2020
@lighterowl
Copy link
Contributor

I'm all for correcting spelling mistakes - but we can easily keep backwards compatibility here. How about, if family doesn't exist, trying to read famaly in order to import the old setting?

@justdan96
Copy link
Owner Author

You're right - I was breaking my own rule here "don't break current functionality". I'll add the functionality to check for "famaly" too.

@justdan96 justdan96 added the wip Work in Progress label Jan 8, 2020
@jcdr428
Copy link
Collaborator

jcdr428 commented Jan 14, 2020

@justdan96 I hope you don't mind me jumping on your wip, but you seem busy -and I really would like to see version 2.6.16 released asap ;)
Replace

  QString fontName = settings->value("famaly").toString();

with

  // keep backward compatibility with versions < 2.6.15 which contain "famaly" key
  if (settings->contains("famaly")) {
    settings->setValue("family", settings->value("famaly"));
    settings->remove("famaly");
  }
  QString fontName = settings->value("family").toString();

@lighterowl lighterowl merged commit 66121f6 into master Jan 14, 2020
@justdan96
Copy link
Owner Author

Thanks for sorting this, I've been a bit busy recently!

@lighterowl
Copy link
Contributor

No worries - figured as much. :-)

@justdan96 justdan96 removed the wip Work in Progress label Feb 4, 2020
@justdan96 justdan96 deleted the enhancement-famaly-to-family branch March 22, 2020 22:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants