-
Notifications
You must be signed in to change notification settings - Fork 163
Fix fps info #130
Fix fps info #130
Conversation
Hopefully last bug on fps reading...
|
Should fix #89. |
|
Has this been tested with a variety of sources, so we can check for regressions? |
|
@justdan96 I've tested with five files: .mkv, .ts, .hevc, hevc .m2ts, avc .m2ts Edit : you can test result on Unreal_Engine_4_-_Elemental_Demo___2160p60_x264_CRF16_YUV420-HEVC-x265.mp4, eg by muxing this file with an srt in an mkv container, and inputting in m2ts. |
|
Wanted to merge this tonight, but I can't reproduce the issue no matter how hard I try. Let's wait until we get a reply on #89. |
|
@Xavery agreed. The two samples I was sent (from W10x64 users, same as me) didn't produce any issue, it is strange that the behavior is not consistent between PCs. Edit: I've received additonal feedback: srt with hevc now seems to be fixed, the bug is still there on h264. So I'll look the code to see if the same fix is to be applied to the other stream readers (AVC, VC-1...) |
To keep consistency with other stream info...
|
GUI issue reproduced and fixed. Roman was trying too hard to do the right thing and it came back to bite us on the butt - in his credit, though, locale-dependent behaviour in text parsing functions changed a bit between Qt 4 and Qt 5. I'll prepare a bigger commit which hopefully cleans this up. For now, this solves the immediate issue. |
Hopefully last bug on fps reading...