This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Fixes and cleanups #66
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've never been a huge fan of custom platform defines which need to be supplied by the build system, especially when these defines can be replaced by checks relying on the presence/value of standard defines which are supplied by the operating system headers and/or the compiler :
_WIN32is defined for all 32- and 64-bit Windows environments, and can thus replaceWIN32.__linux__define is set to 1 on systems using the Linux kernel, and can thus replaceLINUX.__APPLE__and__MACH__are defined - such a check can replaceMAC.As a bonus, remove all unused source and header files from the tree. I don't think moving stuff to
unusedserves any purpose anymore.This was tested on Windows (MSVC and MSYS2), Linux (GCC), and MacOS via osxcross.