added algos/strategy classes + structs for inputs by ab320012 · Pull Request #230 · jwt/ruby-jwt

ab320012 · 2017-09-07T13:27:24Z

made changes discussed here: #229 , changes don't affect the public api.

sourcelevel-bot · 2017-09-07T13:27:49Z

+      }

+      raise JWT::VerificationError, 'Algorithm not supported' if algo.nil?
+      verified = algo.verify(ToVerify.new(algorithm, key, signing_input, signature)) 


Trailing whitespace detected.

sourcelevel-bot · 2017-09-07T13:27:49Z

-      end
+    def verify(algorithm, key, signing_input, signature)
+      algo = ALGOS.find{|algo|
+        algo.const_get(:SUPPORTED).include? algorithm 


Trailing whitespace detected.

sourcelevel-bot · 2017-09-07T13:27:49Z

+        algo.const_get(:SUPPORTED).include? algorithm 
+      } 
+      raise NotImplementedError, 'Unsupported signing method' if algo.nil? 
+      algo.sign ToSign.new(algorithm, msg, key) 


Trailing whitespace detected.

sourcelevel-bot · 2017-09-07T13:27:49Z

+      algo = ALGOS.find{|algo|
+        algo.const_get(:SUPPORTED).include? algorithm 
+      } 
+      raise NotImplementedError, 'Unsupported signing method' if algo.nil? 


Trailing whitespace detected.

sourcelevel-bot · 2017-09-07T13:27:50Z

-      end
+      algo = ALGOS.find{|algo|
+        algo.const_get(:SUPPORTED).include? algorithm 
+      } 


Trailing whitespace detected.

sourcelevel-bot · 2017-09-07T13:27:50Z

+module JWT
+  module Algos
+    module Ecdsa
+      extend self


Use module_function instead of extend self.

sourcelevel-bot · 2017-09-07T13:27:51Z

+        SecurityUtils.asn1_to_raw(key.dsa_sign_asn1(digest.digest(msg)), key)
+      end
+
+      def verify to_verify


Use def with parentheses when there are parameters.

sourcelevel-bot · 2017-09-07T13:27:51Z

+        'secp521r1' => 'ES512'
+      }.freeze
+
+      def sign to_sign


Use def with parentheses when there are parameters.

sourcelevel-bot · 2017-09-07T13:27:51Z

+module JWT
+  module Algos
+    module Eddsa
+      extend self


Use module_function instead of extend self.

sourcelevel-bot · 2017-09-07T13:27:51Z

+        key.sign(msg)
+      end
+
+      def verify to_verify


Use def with parentheses when there are parameters.

sourcelevel-bot · 2017-09-07T13:34:36Z

+      module_function
+      SUPPORTED = %w(ED25519).freeze
+
+      def sign to_sign


Use def with parentheses when there are parameters.

sourcelevel-bot · 2017-09-07T13:34:37Z

+module JWT
+  module Algos
+    module Rsa
+      module_function


Keep a blank line after module_function.

sourcelevel-bot · 2017-09-07T13:34:37Z

+module JWT
+  module Algos
+    module Hmac
+      module_function


Keep a blank line after module_function.

sourcelevel-bot · 2017-09-07T13:34:37Z

+        alg.const_get(:SUPPORTED).include? algorithm
      end
-
+      raise JWT::VerificationError, 'Algorithm not supported' if algo.nil?


JWT::Signature#verify performs a nil-check

Read more about it here.

sourcelevel-bot · 2017-09-07T14:09:55Z

+      def verify(*)
+        raise JWT::VerificationError, 'Algorithm not supported'
+      end
+      def sign(*)


Use empty lines between method definitions.

sourcelevel-bot · 2017-09-07T15:45:49Z

+    module Unsupported
+      module_function
+
+      SUPPORTED = Object.new.tap{ |o| o.define_singleton_method(:include?){ |*| true }}  


Trailing whitespace detected.

sourcelevel-bot · 2017-09-07T15:45:50Z

+    module Unsupported
+      module_function
+
+      SUPPORTED = Object.new.tap{ |o| o.define_singleton_method(:include?){ |*| true }}  


Space missing inside }.

sourcelevel-bot · 2017-09-07T15:45:50Z

+    module Unsupported
+      module_function
+
+      SUPPORTED = Object.new.tap{ |o| o.define_singleton_method(:include?){ |*| true }}  


Space missing to the left of {.

sourcelevel-bot · 2017-09-07T15:45:50Z

+    module Unsupported
+      module_function
+
+      SUPPORTED = Object.new.tap{ |o| o.define_singleton_method(:include?){ |*| true }}  


Space missing to the left of {.

sourcelevel-bot · 2017-09-07T15:45:50Z

+    module Unsupported
+      module_function
+
+      SUPPORTED = Object.new.tap{ |o| o.define_singleton_method(:include?){ |*| true }}  


JWT::Algos::Unsupported has the variable name 'o'

Read more about it here.

sourcelevel-bot · 2017-09-07T15:52:04Z

Ebert has finished reviewing this Pull Request and has found:

14 fixed issues! 🎉

You can see more details about this review at https://ebertapp.io/github/jwt/ruby-jwt/pulls/230.

excpt

Thank you very much. Great refactoring. 🥇

ab320012 added 3 commits September 7, 2017 09:03

moved each sig strategy into seperate classes

df087ee

Merge branch 'master' of https://github.com/jwt/ruby-jwt

6b831fb

froze supported in class

33673af

sourcelevel-bot Bot reviewed Sep 7, 2017

View reviewed changes

trailing white spaces, added do isntead of {}, parens to methods

1d76a28

sourcelevel-bot Bot reviewed Sep 7, 2017

View reviewed changes

ab320012 added 2 commits September 7, 2017 09:41

added spaces after module_function

b03fefd

added unsupported case to remove nil check

e32f842

sourcelevel-bot Bot reviewed Sep 7, 2017

View reviewed changes

ab320012 added 2 commits September 7, 2017 10:10

space between method def in unsupported case

7a28308

simplified unsupported class SUPPORTED constant

51e1208

sourcelevel-bot Bot reviewed Sep 7, 2017

View reviewed changes

ab320012 added 2 commits September 7, 2017 11:48

fixed spaces

adff541

remove whitespaces

a0373a5

excpt approved these changes Sep 9, 2017

View reviewed changes

excpt merged commit 51a162f into jwt:master Sep 9, 2017

Conversation

ab320012 commented Sep 7, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sourcelevel-bot Bot Sep 7, 2017

Choose a reason for hiding this comment

Uh oh!

sourcelevel-bot Bot Sep 7, 2017

Choose a reason for hiding this comment

Uh oh!

sourcelevel-bot Bot Sep 7, 2017

Choose a reason for hiding this comment

Uh oh!

sourcelevel-bot Bot Sep 7, 2017

Choose a reason for hiding this comment

Uh oh!

sourcelevel-bot Bot Sep 7, 2017

Choose a reason for hiding this comment

Uh oh!

sourcelevel-bot Bot Sep 7, 2017

Choose a reason for hiding this comment

Uh oh!

sourcelevel-bot Bot Sep 7, 2017

Choose a reason for hiding this comment

Uh oh!

sourcelevel-bot Bot Sep 7, 2017

Choose a reason for hiding this comment

Uh oh!

sourcelevel-bot Bot Sep 7, 2017

Choose a reason for hiding this comment

Uh oh!

sourcelevel-bot Bot Sep 7, 2017

Choose a reason for hiding this comment

Uh oh!

sourcelevel-bot Bot Sep 7, 2017

Choose a reason for hiding this comment

Uh oh!

sourcelevel-bot Bot Sep 7, 2017

Choose a reason for hiding this comment

Uh oh!

sourcelevel-bot Bot Sep 7, 2017

Choose a reason for hiding this comment

Uh oh!

sourcelevel-bot Bot Sep 7, 2017

Choose a reason for hiding this comment

Uh oh!

sourcelevel-bot Bot Sep 7, 2017

Choose a reason for hiding this comment

Uh oh!

sourcelevel-bot Bot Sep 7, 2017

Choose a reason for hiding this comment

Uh oh!

sourcelevel-bot Bot Sep 7, 2017

Choose a reason for hiding this comment

Uh oh!

sourcelevel-bot Bot Sep 7, 2017

Choose a reason for hiding this comment

Uh oh!

sourcelevel-bot Bot Sep 7, 2017

Choose a reason for hiding this comment

Uh oh!

sourcelevel-bot Bot Sep 7, 2017

Choose a reason for hiding this comment

Uh oh!

sourcelevel-bot Bot commented Sep 7, 2017

Uh oh!

excpt left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ab320012 commented Sep 7, 2017 •

edited

Loading