Merged
Conversation
excpt
requested changes
Mar 22, 2018
Member
excpt
left a comment
excpt
left a comment
There was a problem hiding this comment.
A test should be added to ensure that the leeway is not applied to the iat claim when the token is verified.
| Verify.verify_iat(payload, options) | ||
| end | ||
|
|
||
| it 'must allow configured leeway' do |
Member
There was a problem hiding this comment.
It would be better to invert one of these tests to ensure that the leeway is ignored.
Member
|
@ab320012 Thank you for the PR! I added my review. :) Let me know if you have the time to improve that or if any help is needed. |
excpt
changed the title
|
Thanks, guys! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #247.