Skip to content

Enable rubocop locally and on ci#390

Merged
anakinj merged 1 commit intojwt:masterfrom
anakinj:enable-rubocop
Dec 23, 2020
Merged

Enable rubocop locally and on ci#390
anakinj merged 1 commit intojwt:masterfrom
anakinj:enable-rubocop

Conversation

@anakinj
Copy link
Copy Markdown
Member

@anakinj anakinj commented Dec 14, 2020

Been struggling with sourcelevel-bot spamming PRs with comments about linting issues like extra whitespaces and such.

This PR adds the possibility to run rubocop locally to catch issues early in the process.

The version should be the same as Codeclimate is using(https://docs.codeclimate.com/docs/rubocop)

@sourcelevel-bot
Copy link
Copy Markdown

SourceLevel has finished reviewing this Pull Request and has found:

  • 1 possible new issue (including those that may have been commented here).
  • 5 fixed issues! 🎉

See more details about this review.

@anakinj
Copy link
Copy Markdown
Member Author

anakinj commented Dec 21, 2020

@excpt Im thinking of merging this to improve the local experience when developing the gem.

@anakinj anakinj merged commit 10b7dd4 into jwt:master Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant