Skip to content

Conversation

@antonym
Copy link
Contributor

@antonym antonym commented Dec 1, 2025

NetworkManager exists in /usr/sbin/NetworkManager by default.

NetworkManager exists in /usr/sbin/NetworkManager by default.
Copilot AI review requested due to automatic review settings December 1, 2025 08:00
@antonym antonym requested a review from a team as a code owner December 1, 2025 08:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects the file system path used to check for the NetworkManager binary from /usr/bin/NetworkManager to /usr/sbin/NetworkManager, which is the standard location for this system binary.

  • Updates the path check for NetworkManager to use the correct /usr/sbin directory
  • Ensures consistency with other NetworkManager path references in the codebase (line 505)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Copy link
Member

@Itxaka Itxaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are completely rigth, thanks for the patch!

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.66%. Comparing base (68cca9a) to head (cba55f2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #245   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files           1        1           
  Lines         168      168           
=======================================
  Hits          112      112           
  Misses         39       39           
  Partials       17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Itxaka Itxaka merged commit b0f0656 into kairos-io:main Dec 1, 2025
39 of 40 checks passed
@Itxaka Itxaka mentioned this pull request Dec 9, 2025
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants