Skip to content

duplicate ph language tag#9

Merged
kanakawai-maui merged 1 commit intomainfrom
duplicate-ph-tag
Apr 22, 2025
Merged

duplicate ph language tag#9
kanakawai-maui merged 1 commit intomainfrom
duplicate-ph-tag

Conversation

@ryansherring
Copy link
Copy Markdown
Collaborator

@ryansherring ryansherring commented Apr 21, 2025

this first pr is super small. I noticed Tagolog and Filipino share a flag, which i imagine could be a problem. I am less versed in i18n though so feel free to correct me on this. Essentially, I moved tagolog to be the native name of Filipino and deleted the second object reusing the tag. I'm a bit busy but i'll push up some other, more code-y pr's later!

@ryansherring ryansherring requested a review from brownrw8 April 21, 2025 18:22
},
{
"code": "tl",
"nativeName": "Filipino",
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@kanakawai-maui kanakawai-maui merged commit ed255ce into main Apr 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants