More flexible signal propagation #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a few more configuration options around signal handling: - allow specifying the "stop signal" to pass to the child process, in case the child does not happen to handle SIGTERM. - allow suppressing the exit code of the child process to 0 if the child does not gracefully exit when being stopped, but the caller needs that to happen (typically the case for k8s jobs). Since we happen to extend configurations, also allow enabling logging with timestamps, which had been set to off. All configurations are optional and backwards compatible.
ckolbitsch-work
force-pushed
the
allow-exit-0
branch
from
3b90561 to
c2d08aa
Compare
We were unconditionally suppressing child process exit codes in case KUBEXIT_SUPPRESS_STOPPED_EXITCODE was set. Ensure to only change the exit code if stopping the child from kubexit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a few more configuration options around signal handling:
case the child does not happen to handle SIGTERM.
does not gracefully exit when being stopped, but the caller needs that
to happen (typically the case for k8s jobs).
Since we happen to extend configurations, also allow enabling logging
with timestamps, which had been set to off.
All configurations are optional and backwards compatible.