Skip to content

feat: allow top_k=0 in web api to disable filtering #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karpathy merged 4 commits into from
Jan 30, 2026
Merged

feat: allow top_k=0 in web api to disable filtering #458

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
445e879
allow top_k=0 in web api to disable filtering
aarushisingh04 Jan 8, 2026
8f6e616
Merge branch 'master' into topk-validation-fix
aarushisingh04 Jan 23, 2026
04d816e
adding a comment for clear reasoning
aarushisingh04 Jan 23, 2026
135f25e
adding change to docstring
aarushisingh04 Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scripts/chat_web.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
- Maximum 8000 characters per message
- Maximum 32000 characters total conversation length
- Temperature clamped to 0.0-2.0
- Top-k clamped to 1-200
- Top-k clamped to 0-200 (0 disables top-k filtering, using full vocabulary)
- Max tokens clamped to 1-4096
"""

Expand Down Expand Up @@ -55,7 +55,7 @@
MAX_TOTAL_CONVERSATION_LENGTH = 32000
MIN_TEMPERATURE = 0.0
MAX_TEMPERATURE = 2.0
MIN_TOP_K = 1
MIN_TOP_K = 0 # 0 disables top-k filtering, using full vocabulary
MAX_TOP_K = 200
MIN_MAX_TOKENS = 1
MAX_MAX_TOKENS = 4096
Expand Down