Key should fire continuously when key is held down

[kasper]

Key should fire continuously when key is held down. Use [NSEvent keyRepeatInterval] as the interval.

• Version: 2.2
• macOS: 10.11.5

[mafredri]

Should Phoenix consider the initial key repeat interval as well to better mimic keyboard behaviour?

defaults read -g InitialKeyRepeat
defaults read -g KeyRepeat

[kasper]

@mafredri Yes, I think that is what [NSEvent keyRepeatDelay] is for.

[mafredri]

Oh, my bad, should've checked 👍.

[kasper]

The strategy is now:

1. Key down, call callback
2. Start delay timer
3. After delay, call callback
4. Start interval timer
5. After interval, call callback
6. Key up, invalidate timer

[kasper]

You can now test this from the feature-key-repeat-branch. There’s still something essentially wrong with the timers if you try to do something weird like this:

var a = new Key('e', [ 'ctrl', 'shift' ], function () {
  Phoenix.log('A');
  b.enable();
});

var b = new Key('e', [ 'ctrl', 'shift' ], function () {
  Phoenix.log('B');
  a.enable();
});

[kasper]

Oh and I delayed this feature so I could release 2.2.1 with the critical bug fixes. Better not to botch this up. 😏

[khalidchawtany]

It's 1:00 am and posting from bed :)
I will test the feature branch tomorrow.
Thank you vey much 👍

[khalidchawtany]

I just tried it and it is awesome :)