Skip to content

[STUDIO-5046] Bump up jenkins core to 2.448 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TriLeKatalon merged 1 commit into from
Mar 20, 2024
Merged

[STUDIO-5046] Bump up jenkins core to 2.448 #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ Use the command `mvn clean hpi:run -Djetty.port=8090` to debug the plugin.

See the instructions at https://wiki.jenkins.io/display/JENKINS/Plugin+tutorial.

### Requisition

Jenkins: 2.448

## Companion products

### Katalon TestOps
Expand Down
10 changes: 4 additions & 6 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,30 +5,28 @@
<parent>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>plugin</artifactId>
<version>4.64</version>
<version>4.79</version>
<relativePath />
</parent>

<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>katalon</artifactId>
<version>1.0.35</version>
<version>1.0.36</version>
<packaging>hpi</packaging>
<name>Katalon Plugin</name>
<url>https://github.com/jenkinsci/katalon-plugin</url>

<properties>
<!-- Baseline Jenkins version you use to build the plugin. Users must have this version or newer to run. -->
<jenkins.version>2.361.4</jenkins.version>
Copy link
Copy Markdown

@TriLeKatalon TriLeKatalon Mar 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we apply a different format of this version?

<jenkins.version>2.448</jenkins.version>
<java.level>17</java.level>
<!-- Other properties you may want to use:
~ java.level: set to 6 if your jenkins.version <= 1.611 ~ jenkins-test-harness.version: Jenkins Test Harness version you use to test the plugin. For Jenkins version >= 1.580.1 use JTH 2.0 or higher.
~ hpi-plugin.version: The HPI Maven Plugin version used by the plugin..
~ stapler-plugin.version: The Stapler Maven plugin version required by the plugin.
-->
<junit.plugin.version>1.20</junit.plugin.version>
<jackson.version>2.13.13</jackson.version>
<commons-lang3.version>3.12.0</commons-lang3.version>
<utils.version>1.0.17</utils.version>
<utils.version>1.0.18</utils.version>
<httpclient.version>4.5.13</httpclient.version>
</properties>

Expand Down
7 changes: 6 additions & 1 deletion src/main/java/com/katalon/jenkins/plugin/helper/ExecuteKatalonStudioHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import hudson.FilePath;
import hudson.Launcher;
import hudson.model.TaskListener;
import hudson.remoting.VirtualChannel;
import jenkins.security.MasterToSlaveCallable;

import java.util.HashMap;
Expand All @@ -26,7 +27,11 @@ public static boolean executeKatalon(
String xvfbConfiguration) {
Logger logger = new JenkinsLogger(taskListener);
try {
return launcher.getChannel().call(new MasterToSlaveCallable<Boolean, Exception>() {
VirtualChannel channel = launcher.getChannel();
if (channel == null) {
throw new Exception("Channel not found!");
}
return channel.call(new MasterToSlaveCallable<Boolean, Exception>() {
@Override
public Boolean call() throws Exception {

Expand Down