Skip to content

Conversation

@devnoname120
Copy link
Contributor

@devnoname120 devnoname120 commented Jan 6, 2025

  • change service notification to AirPods not connected
  • fix service killed by Android battery saver
  • improve notification to hide L: / R: / C: when either is missing

Preview:
Screenshot_20250106-201232

@kavishdevar
Copy link
Owner

resolving conflicts and merging right away. thanks! also fixing your other comment about 0% rn.

@devnoname120
Copy link
Contributor Author

devnoname120 commented Jan 6, 2025

@kavishdevar Note that we may want to show the C: 31% if there is actually a valid last known value :)

@kavishdevar kavishdevar merged commit 5d9f91a into kavishdevar:main Jan 6, 2025
@kavishdevar
Copy link
Owner

kavishdevar commented Jan 6, 2025

@devnoname120 I'll look into the last saved thingy tomorrow and the null in the popup. gotta sleep now :]

@devnoname120
Copy link
Contributor Author

Great thanks a lot!

You don't need to look at it immediately (it will be for another time) but I compiled 2c2552a and it seems to sometimes “lose” the last case battery value, usually when I remove or insert the AirPods. I guess it's overriden to 0 if it's missing from a Bluetooth packet or something? I also managed to get a -1% for the case level once or twice on the app main screen. 😁

Here is a video where I do a bunch of things like inserting the AirPods into the case, removing them, closing the case, opening it again, and so on:

screen-20250106-205602.mp4

Not super easy to understand what's going on just from the screen recording but hopefully you should be able to reproduce it easily :)

@devnoname120 devnoname120 deleted the improve-notification branch January 6, 2025 20:04
@kavishdevar
Copy link
Owner

kavishdevar commented Jan 6, 2025

fixed it anyway, the null! such a stupid bug it was :|

and it seems to sometimes “lose” the last case battery value, usually when I remove or insert the AirPods. I guess it's overriden to 0 if it's missing from a Bluetooth packet or something

huh, I'll look into it. I have it so that the battery status is not overwritten if it’s disconnected. I'll try to reproduce it though.

I also managed to get a -1% for the case level once or twice on the app main screen. 😁

lol that's on airpods, I had seen it quite some time ago. I don't set it to -1 anywhere.

Not super easy to understand what's going on just from the screen recording but hopefully you should be able to reproduce it easily :)

yeah! I am guessing this might be when the airpods send a packet saying the case is connected, but the value is 0 or -1. I'll try to reprod...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants