Add more documentation #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavishdevar
previously requested changes
Apr 16, 2025
Owner
kavishdevar
left a comment
kavishdevar
left a comment
There was a problem hiding this comment.
One small thing, if you're able to add it, or you can merge it and I'll add the details later.
Could you please add the lengths and offsets of the different parts of the packet? I understand that the lengths might not be fixed. So maybe Apple uses a separator/spacer or a header for each part if the packet?
^ for the main doc.
kavishdevar
dismissed
their stale review
I'll make the changes myself after merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds documentation for: