[Linux] Improve connection stability #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-gromeyer
force-pushed
the
linux-disconnect-behaviour
branch
from
cdb8f42 to
abfbe5e
Compare
Owner
|
I think it's great! Maybe for automatically connecting, we can still use dbus for listening to changes? |
Contributor
Author
|
Yeah, of course we can, but I think it should be a option you can turn off |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For me the old method with QBluetoothDeviceDiscoveryAgent the connecting was pretty unstable.
It was disconnecting after a short amount of time, always. Since we already rely on BlueZ (only supported backend in Qt for Linux), I use the bluez dbus api to check for connected/disconnected devices.
Our Qt code than only connects to the service, not the device itself.
With this change I noticed a improvement in the time it takes for the app to connect to the airpods.
It's a pretty big change, and I wanna know what you think about it (@kavishdevar). I only noticed improvements.
Upsides I know of:
Possible downsides: