Skip to content

Fix for lifecycle events / mac scripts & --no-arguments option #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 4, 2019

Conversation

jimcatts
Copy link

It looked like this was the preferred fork for lifecycle events - I ran into some issues with scripts on the mac and with the second argument in the original command ("version" in "npm version patch") overriding the lifecycle event ("postversion").

Small refactor to give npm_lifecycle_event priority over npm_config_argv to support lifecycle events.

Fixed an issue with no scripts found on mac (darwin or nix)

Also, added --no-arguments option to fix charlesguse#23

@jimcatts jimcatts changed the title Fix for lifecycle events / mac scripts & --no-arguments option Sep 16, 2019
@kawatzaki
Copy link
Owner

Wow this looks pretty good!

I'm sorry I don't know why GitHub didn't consider this important enough to send me an email about it...

I'll check it out and it'll be merged soon enough :)

@doctor-amaton doctor-amaton merged commit 63fa688 into kawatzaki:master Oct 4, 2019
@doctor-amaton
Copy link
Collaborator

Done!

I can't believe a switch fall-through going on!
Thanks for the fix, I'll just change a couple of spaces here and there to make my OCD happy...

I'll be updating the npm package pretty soon.

@doctor-amaton
Copy link
Collaborator

OK, I've updated the npm package to version 1.1.3.

Also, in the future, https://github.com/kawatzaki/dr.amaton-run-script-os should be a better repo to do additional changing, as is the npm package repo (good package.json).

I'll try keep an eye on PRs more often!

@ibc
Copy link

ibc commented Oct 4, 2019

Sorry if this is a stupid question, but I'm confused. My project currently depends on @dr.amaton/run-script-os but given that there are also commits here it's not clear which is the appropriate project I should use.

Is this? or is it this?

@kawatzaki
Copy link
Owner

kawatzaki commented Oct 4, 2019

@ibc Hello there :P

Well this repository is "ready" to be merged whenever @charlesguse wakes up from his Odin Sleep...

The one I suggested on my previous comment (https://github.com/kawatzaki/dr.amaton-run-script-os) is identical, it only has a different package.json, which makes reference to the npm @dr.amaton/run-script-os

I hope that clears your doubts!

@ibc
Copy link

ibc commented Oct 4, 2019

Sure, clear. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arguments to lifecycle events
4 participants