Skip to content
This repository was archived by the owner on Apr 24, 2024. It is now read-only.

make: add an end-to-end test #19

Merged
merged 1 commit into from
Sep 2, 2022
Merged

make: add an end-to-end test #19

merged 1 commit into from
Sep 2, 2022

Conversation

stevekuznetsov
Copy link
Contributor

Signed-off-by: Steve Kuznetsov [email protected]

@stevekuznetsov
Copy link
Contributor Author

Must be doing something wrong, blocked on kcp-dev/kcp#1742

stevekuznetsov
stevekuznetsov commented Aug 12, 2022
View reviewed changes
@stevekuznetsov stevekuznetsov force-pushed the skuznets/e2e branch 4 times, most recently from b65e2eb to 1b17c3a Compare August 15, 2022 13:47
ncdc
ncdc reviewed Aug 15, 2022
View reviewed changes
@stevekuznetsov stevekuznetsov mentioned this pull request Aug 15, 2022
Merged
@stevekuznetsov stevekuznetsov force-pushed the skuznets/e2e branch 3 times, most recently from 910e0c4 to 541cfb3 Compare August 16, 2022 22:06
@stevekuznetsov stevekuznetsov mentioned this pull request Aug 16, 2022
Merged
@stevekuznetsov stevekuznetsov force-pushed the skuznets/e2e branch 2 times, most recently from a91ceee to 9b82887 Compare August 17, 2022 13:35
@stevekuznetsov stevekuznetsov mentioned this pull request Aug 17, 2022
Closed
8 tasks
@stevekuznetsov stevekuznetsov force-pushed the skuznets/e2e branch 4 times, most recently from e6cb738 to 5c96630 Compare August 18, 2022 13:14
@stevekuznetsov
Copy link
Contributor Author

Depends on openshift/release#31458 (comment)

@stevekuznetsov stevekuznetsov force-pushed the skuznets/e2e branch 2 times, most recently from d97c5a1 to 04f0423 Compare August 18, 2022 16:00
stevekuznetsov
stevekuznetsov commented Aug 18, 2022
View reviewed changes
@stevekuznetsov
make: add an end-to-end test
53203c4 
Signed-off-by: Steve Kuznetsov <[email protected]>
@stevekuznetsov
Copy link
Contributor Author

@ncdc this is ready for review

@stevekuznetsov
Copy link
Contributor Author

/test all

@ncdc
Copy link
Member

ncdc commented Sep 2, 2022

/override ci/prow/e2e

@openshift-ci
Copy link

openshift-ci bot commented Sep 2, 2022

@ncdc: Overrode contexts on behalf of ncdc: ci/prow/e2e

In response to this:

/override ci/prow/e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ncdc,stevekuznetsov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2022
@openshift-merge-robot openshift-merge-robot merged commit 733db4e into kcp-dev:main Sep 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ncdc ncdc ncdc approved these changes

Assignees

@ncdc ncdc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevekuznetsov @ncdc @openshift-merge-robot