Ignore cluster in ctx for non-aware caches, and error for the inverse #49
Conversation
kcp-ci-bot
added
dco-signoff: yes
sttts
force-pushed
the
sttts-check-cluster-aware
branch
from
57d9cb3 to
6241fd9
Compare
…rror for the inverse Signed-off-by: Dr. Stefan Schimanski <[email protected]>
sttts
force-pushed
the
sttts-check-cluster-aware
branch
from
6241fd9 to
6a7c677
Compare
kcp-ci-bot
added
size/M
|
/assign @embik |
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
|
LGTM label has been added. Git tree hash: a59ac113c8757529eee895c232399abc170f61b3
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
|
/hold for additional reviews :) |
kcp-ci-bot
added
the
do-not-merge/hold
|
/cc @yastij |
|
@embik: GitHub didn't allow me to request PR reviews from the following users: yastij. Note that only kcp-dev members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
@yastij: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold cancel |
kcp-ci-bot
removed
the
do-not-merge/hold
A cluster-aware cache has cluster indexes. Use that to error if a cluster is missing in the context. Inverse, ignore the cluster for a cluster-unaware cache, e.g. one against a normal kube cluster.
Signed-off-by: Dr. Stefan Schimanski [email protected]